Don't swap processes for javascript: URLs.

content/browser/site_instance.h

Index: content/browser/site_instance.h
diff --git a/content/browser/site_instance.h b/content/browser/site_instance.h
index b85aa9ad4050882b08171fa53bac56497430bedc..148ade2633a1355940d17eaeea07533bd07a4c3e 100644
--- a/content/browser/site_instance.h
+++ b/content/browser/site_instance.h
@@ -74,7 +74,8 @@ class CONTENT_EXPORT SiteInstance : public base::RefCounted<SiteInstance>,
   }
 
   // Whether this SiteInstance has a running process associated with it.
-  bool HasProcess() const;
+  // Virtual to allow tests to extend it.
+  virtual bool HasProcess() const;

[awong, 2012/01/12 22:56:41]

It's unfortunate to have a partially-virtual interface -- especially if the
motivating reason is just a unittest.

Can we get away with a SetProcessForTest() that's private and then just friend
the test using the FRIEND_TEST* macros?

[nasko, 2012/01/13 01:34:50]

I rewrote the test differently and now it doesn't require the function to be
virtual.

 
   // Returns the current process being used to render pages in this
   // SiteInstance.  If the process has crashed or otherwise gone away, then