Don't swap processes for javascript: URLs.

content/browser/site_instance.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_SITE_INSTANCE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_SITE_INSTANCE_H_
 #pragma once
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/common/content_export.h"
@@ skipping 56 matching lines @@
   //
   // The factory must outlive the SiteInstance; ownership is not transferred. It
   // may be NULL, in which case the default BrowserRenderProcessHost will be
   // created (this is the behavior if you don't call this function).
   void set_render_process_host_factory(
       content::RenderProcessHostFactory* rph_factory) {
     render_process_host_factory_ = rph_factory;
   }
 
   // Whether this SiteInstance has a running process associated with it.
-  bool HasProcess() const;
+  // Virtual to allow tests to extend it.
+  virtual bool HasProcess() const;

[awong, 2012/01/12 22:56:41]

It's unfortunate to have a partially-virtual interface -- especially if the
motivating reason is just a unittest.

Can we get away with a SetProcessForTest() that's private and then just friend
the test using the FRIEND_TEST* macros?

[nasko, 2012/01/13 01:34:50]

I rewrote the test differently and now it doesn't require the function to be
virtual.

 
   // Returns the current process being used to render pages in this
   // SiteInstance.  If the process has crashed or otherwise gone away, then
   // this method will create a new process and update our host ID accordingly.
   content::RenderProcessHost* GetProcess();
 
   // Set / Get the web site that this SiteInstance is rendering pages for.
   // This includes the scheme and registered domain, but not the port.  If the
   // URL does not have a valid registered domain, then the full hostname is
   // stored.
@@ skipping 104 matching lines @@
   // The web site that this SiteInstance is rendering pages for.
   GURL site_;
 
   // Whether SetSite has been called.
   bool has_site_;
 
   DISALLOW_COPY_AND_ASSIGN(SiteInstance);
 };
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_SITE_INSTANCE_H_