Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: net/base/network_change_notifier.cc

Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Review comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/network_change_notifier.cc
diff --git a/net/base/network_change_notifier.cc b/net/base/network_change_notifier.cc
index ec9cae06d79da8f6beac0145b10ff2635e5206e8..a2dd636a1bcdd09d2f5a8d957e156081a278fe90 100644
--- a/net/base/network_change_notifier.cc
+++ b/net/base/network_change_notifier.cc
@@ -28,7 +28,9 @@ NetworkChangeNotifierFactory* g_network_change_notifier_factory = NULL;
class MockNetworkChangeNotifier : public NetworkChangeNotifier {
public:
- virtual bool IsCurrentlyOffline() const { return false; }
+ virtual ConnectionType GetCurrentConnectionType() const {
+ return CONNECTION_UNKNOWN;
+ }
};
} // namespace
@@ -75,9 +77,11 @@ NetworkChangeNotifier* NetworkChangeNotifier::Create() {
}
// static
-bool NetworkChangeNotifier::IsOffline() {
- return g_network_change_notifier &&
- g_network_change_notifier->IsCurrentlyOffline();
+NetworkChangeNotifier::ConnectionType
+NetworkChangeNotifier::GetConnectionType() {
+ return g_network_change_notifier ?
+ g_network_change_notifier->GetCurrentConnectionType() :
+ CONNECTION_UNKNOWN;
}
// static
@@ -90,10 +94,10 @@ void NetworkChangeNotifier::AddIPAddressObserver(IPAddressObserver* observer) {
g_network_change_notifier->ip_address_observer_list_->AddObserver(observer);
}
-void NetworkChangeNotifier::AddOnlineStateObserver(
- OnlineStateObserver* observer) {
+void NetworkChangeNotifier::AddConnectionTypeObserver(
+ ConnectionTypeObserver* observer) {
if (g_network_change_notifier) {
- g_network_change_notifier->online_state_observer_list_->AddObserver(
+ g_network_change_notifier->connection_type_observer_list_->AddObserver(
observer);
}
}
@@ -113,10 +117,10 @@ void NetworkChangeNotifier::RemoveIPAddressObserver(
}
}
-void NetworkChangeNotifier::RemoveOnlineStateObserver(
- OnlineStateObserver* observer) {
+void NetworkChangeNotifier::RemoveConnectionTypeObserver(
+ ConnectionTypeObserver* observer) {
if (g_network_change_notifier) {
- g_network_change_notifier->online_state_observer_list_->RemoveObserver(
+ g_network_change_notifier->connection_type_observer_list_->RemoveObserver(
observer);
}
}
@@ -132,9 +136,9 @@ NetworkChangeNotifier::NetworkChangeNotifier()
: ip_address_observer_list_(
new ObserverListThreadSafe<IPAddressObserver>(
ObserverListBase<IPAddressObserver>::NOTIFY_EXISTING_ONLY)),
- online_state_observer_list_(
- new ObserverListThreadSafe<OnlineStateObserver>(
- ObserverListBase<OnlineStateObserver>::NOTIFY_EXISTING_ONLY)),
+ connection_type_observer_list_(
+ new ObserverListThreadSafe<ConnectionTypeObserver>(
+ ObserverListBase<ConnectionTypeObserver>::NOTIFY_EXISTING_ONLY)),
resolver_state_observer_list_(
new ObserverListThreadSafe<DNSObserver>(
ObserverListBase<DNSObserver>::NOTIFY_EXISTING_ONLY)) {
@@ -156,10 +160,11 @@ void NetworkChangeNotifier::NotifyObserversOfDNSChange(unsigned detail) {
}
}
-void NetworkChangeNotifier::NotifyObserversOfOnlineStateChange() {
+void NetworkChangeNotifier::NotifyObserversOfConnectionTypeChange() {
if (g_network_change_notifier) {
- g_network_change_notifier->online_state_observer_list_->Notify(
- &OnlineStateObserver::OnOnlineStateChanged, !IsOffline());
+ g_network_change_notifier->connection_type_observer_list_->Notify(
+ &ConnectionTypeObserver::OnConnectionTypeChanged,
+ GetConnectionType());
}
}

Powered by Google App Engine
This is Rietveld 408576698