Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: net/base/network_change_notifier.cc

Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Review comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/network_change_notifier.h" 5 #include "net/base/network_change_notifier.h"
6 #include "net/base/network_change_notifier_factory.h" 6 #include "net/base/network_change_notifier_factory.h"
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #if defined(OS_WIN) 8 #if defined(OS_WIN)
9 #include "net/base/network_change_notifier_win.h" 9 #include "net/base/network_change_notifier_win.h"
10 #elif defined(OS_LINUX) && !defined(OS_CHROMEOS) 10 #elif defined(OS_LINUX) && !defined(OS_CHROMEOS)
(...skipping 10 matching lines...) Expand all
21 // in ways that would require us to place locks around access to this object. 21 // in ways that would require us to place locks around access to this object.
22 // (The prohibition on global non-POD objects makes it tricky to do such a thing 22 // (The prohibition on global non-POD objects makes it tricky to do such a thing
23 // anyway.) 23 // anyway.)
24 NetworkChangeNotifier* g_network_change_notifier = NULL; 24 NetworkChangeNotifier* g_network_change_notifier = NULL;
25 25
26 // Class factory singleton. 26 // Class factory singleton.
27 NetworkChangeNotifierFactory* g_network_change_notifier_factory = NULL; 27 NetworkChangeNotifierFactory* g_network_change_notifier_factory = NULL;
28 28
29 class MockNetworkChangeNotifier : public NetworkChangeNotifier { 29 class MockNetworkChangeNotifier : public NetworkChangeNotifier {
30 public: 30 public:
31 virtual bool IsCurrentlyOffline() const { return false; } 31 virtual ConnectionType GetCurrentConnectionType() const {
32 return CONNECTION_UNKNOWN;
33 }
32 }; 34 };
33 35
34 } // namespace 36 } // namespace
35 37
36 NetworkChangeNotifier::~NetworkChangeNotifier() { 38 NetworkChangeNotifier::~NetworkChangeNotifier() {
37 DCHECK_EQ(this, g_network_change_notifier); 39 DCHECK_EQ(this, g_network_change_notifier);
38 g_network_change_notifier = NULL; 40 g_network_change_notifier = NULL;
39 } 41 }
40 42
41 // static 43 // static
(...skipping 26 matching lines...) Expand all
68 return NetworkChangeNotifierLinux::Create(); 70 return NetworkChangeNotifierLinux::Create();
69 #elif defined(OS_MACOSX) 71 #elif defined(OS_MACOSX)
70 return new NetworkChangeNotifierMac(); 72 return new NetworkChangeNotifierMac();
71 #else 73 #else
72 NOTIMPLEMENTED(); 74 NOTIMPLEMENTED();
73 return NULL; 75 return NULL;
74 #endif 76 #endif
75 } 77 }
76 78
77 // static 79 // static
78 bool NetworkChangeNotifier::IsOffline() { 80 NetworkChangeNotifier::ConnectionType
79 return g_network_change_notifier && 81 NetworkChangeNotifier::GetConnectionType() {
80 g_network_change_notifier->IsCurrentlyOffline(); 82 return g_network_change_notifier ?
83 g_network_change_notifier->GetCurrentConnectionType() :
84 CONNECTION_UNKNOWN;
81 } 85 }
82 86
83 // static 87 // static
84 NetworkChangeNotifier* NetworkChangeNotifier::CreateMock() { 88 NetworkChangeNotifier* NetworkChangeNotifier::CreateMock() {
85 return new MockNetworkChangeNotifier(); 89 return new MockNetworkChangeNotifier();
86 } 90 }
87 91
88 void NetworkChangeNotifier::AddIPAddressObserver(IPAddressObserver* observer) { 92 void NetworkChangeNotifier::AddIPAddressObserver(IPAddressObserver* observer) {
89 if (g_network_change_notifier) 93 if (g_network_change_notifier)
90 g_network_change_notifier->ip_address_observer_list_->AddObserver(observer); 94 g_network_change_notifier->ip_address_observer_list_->AddObserver(observer);
91 } 95 }
92 96
93 void NetworkChangeNotifier::AddOnlineStateObserver( 97 void NetworkChangeNotifier::AddConnectionTypeObserver(
94 OnlineStateObserver* observer) { 98 ConnectionTypeObserver* observer) {
95 if (g_network_change_notifier) { 99 if (g_network_change_notifier) {
96 g_network_change_notifier->online_state_observer_list_->AddObserver( 100 g_network_change_notifier->connection_type_observer_list_->AddObserver(
97 observer); 101 observer);
98 } 102 }
99 } 103 }
100 104
101 void NetworkChangeNotifier::AddDNSObserver(DNSObserver* observer) { 105 void NetworkChangeNotifier::AddDNSObserver(DNSObserver* observer) {
102 if (g_network_change_notifier) { 106 if (g_network_change_notifier) {
103 g_network_change_notifier->resolver_state_observer_list_->AddObserver( 107 g_network_change_notifier->resolver_state_observer_list_->AddObserver(
104 observer); 108 observer);
105 } 109 }
106 } 110 }
107 111
108 void NetworkChangeNotifier::RemoveIPAddressObserver( 112 void NetworkChangeNotifier::RemoveIPAddressObserver(
109 IPAddressObserver* observer) { 113 IPAddressObserver* observer) {
110 if (g_network_change_notifier) { 114 if (g_network_change_notifier) {
111 g_network_change_notifier->ip_address_observer_list_->RemoveObserver( 115 g_network_change_notifier->ip_address_observer_list_->RemoveObserver(
112 observer); 116 observer);
113 } 117 }
114 } 118 }
115 119
116 void NetworkChangeNotifier::RemoveOnlineStateObserver( 120 void NetworkChangeNotifier::RemoveConnectionTypeObserver(
117 OnlineStateObserver* observer) { 121 ConnectionTypeObserver* observer) {
118 if (g_network_change_notifier) { 122 if (g_network_change_notifier) {
119 g_network_change_notifier->online_state_observer_list_->RemoveObserver( 123 g_network_change_notifier->connection_type_observer_list_->RemoveObserver(
120 observer); 124 observer);
121 } 125 }
122 } 126 }
123 127
124 void NetworkChangeNotifier::RemoveDNSObserver(DNSObserver* observer) { 128 void NetworkChangeNotifier::RemoveDNSObserver(DNSObserver* observer) {
125 if (g_network_change_notifier) { 129 if (g_network_change_notifier) {
126 g_network_change_notifier->resolver_state_observer_list_->RemoveObserver( 130 g_network_change_notifier->resolver_state_observer_list_->RemoveObserver(
127 observer); 131 observer);
128 } 132 }
129 } 133 }
130 134
131 NetworkChangeNotifier::NetworkChangeNotifier() 135 NetworkChangeNotifier::NetworkChangeNotifier()
132 : ip_address_observer_list_( 136 : ip_address_observer_list_(
133 new ObserverListThreadSafe<IPAddressObserver>( 137 new ObserverListThreadSafe<IPAddressObserver>(
134 ObserverListBase<IPAddressObserver>::NOTIFY_EXISTING_ONLY)), 138 ObserverListBase<IPAddressObserver>::NOTIFY_EXISTING_ONLY)),
135 online_state_observer_list_( 139 connection_type_observer_list_(
136 new ObserverListThreadSafe<OnlineStateObserver>( 140 new ObserverListThreadSafe<ConnectionTypeObserver>(
137 ObserverListBase<OnlineStateObserver>::NOTIFY_EXISTING_ONLY)), 141 ObserverListBase<ConnectionTypeObserver>::NOTIFY_EXISTING_ONLY)),
138 resolver_state_observer_list_( 142 resolver_state_observer_list_(
139 new ObserverListThreadSafe<DNSObserver>( 143 new ObserverListThreadSafe<DNSObserver>(
140 ObserverListBase<DNSObserver>::NOTIFY_EXISTING_ONLY)) { 144 ObserverListBase<DNSObserver>::NOTIFY_EXISTING_ONLY)) {
141 DCHECK(!g_network_change_notifier); 145 DCHECK(!g_network_change_notifier);
142 g_network_change_notifier = this; 146 g_network_change_notifier = this;
143 } 147 }
144 148
145 void NetworkChangeNotifier::NotifyObserversOfIPAddressChange() { 149 void NetworkChangeNotifier::NotifyObserversOfIPAddressChange() {
146 if (g_network_change_notifier) { 150 if (g_network_change_notifier) {
147 g_network_change_notifier->ip_address_observer_list_->Notify( 151 g_network_change_notifier->ip_address_observer_list_->Notify(
148 &IPAddressObserver::OnIPAddressChanged); 152 &IPAddressObserver::OnIPAddressChanged);
149 } 153 }
150 } 154 }
151 155
152 void NetworkChangeNotifier::NotifyObserversOfDNSChange(unsigned detail) { 156 void NetworkChangeNotifier::NotifyObserversOfDNSChange(unsigned detail) {
153 if (g_network_change_notifier) { 157 if (g_network_change_notifier) {
154 g_network_change_notifier->resolver_state_observer_list_->Notify( 158 g_network_change_notifier->resolver_state_observer_list_->Notify(
155 &DNSObserver::OnDNSChanged, detail); 159 &DNSObserver::OnDNSChanged, detail);
156 } 160 }
157 } 161 }
158 162
159 void NetworkChangeNotifier::NotifyObserversOfOnlineStateChange() { 163 void NetworkChangeNotifier::NotifyObserversOfConnectionTypeChange() {
160 if (g_network_change_notifier) { 164 if (g_network_change_notifier) {
161 g_network_change_notifier->online_state_observer_list_->Notify( 165 g_network_change_notifier->connection_type_observer_list_->Notify(
162 &OnlineStateObserver::OnOnlineStateChanged, !IsOffline()); 166 &ConnectionTypeObserver::OnConnectionTypeChanged,
167 GetConnectionType());
163 } 168 }
164 } 169 }
165 170
166 NetworkChangeNotifier::DisableForTest::DisableForTest() 171 NetworkChangeNotifier::DisableForTest::DisableForTest()
167 : network_change_notifier_(g_network_change_notifier) { 172 : network_change_notifier_(g_network_change_notifier) {
168 DCHECK(g_network_change_notifier); 173 DCHECK(g_network_change_notifier);
169 g_network_change_notifier = NULL; 174 g_network_change_notifier = NULL;
170 } 175 }
171 176
172 NetworkChangeNotifier::DisableForTest::~DisableForTest() { 177 NetworkChangeNotifier::DisableForTest::~DisableForTest() {
173 DCHECK(!g_network_change_notifier); 178 DCHECK(!g_network_change_notifier);
174 g_network_change_notifier = network_change_notifier_; 179 g_network_change_notifier = network_change_notifier_;
175 } 180 }
176 181
177 } // namespace net 182 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698