Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 9139051: Cosmetic changes ("set up" is a verb, "setup" is a noun). (Closed)

Created:
8 years, 11 months ago by Erik Corry
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Cosmetic changes ("set up" is a verb, "setup" is a noun). Committed: http://code.google.com/p/v8/source/detail?r=10399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -401 lines) Patch
M src/arm/assembler-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/builtins-arm.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M src/arm/cpu-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/simulator-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/atomicops_internals_x86_macosx.h View 15 chunks +22 lines, -22 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/cpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/cpu-profiler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/cpu-profiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/d8-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/debug-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gdb-jit.cc View 12 chunks +22 lines, -22 lines 0 comments Download
M src/heap.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/heap.cc View 17 chunks +25 lines, -25 lines 0 comments Download
M src/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M src/ia32/cpu-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/inspector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M src/lithium.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveobjectlist.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/liveobjectlist.cc View 17 chunks +24 lines, -24 lines 0 comments Download
M src/liveobjectlist-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/log.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/log.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/assembler-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M src/mips/constants-mips.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/cpu-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/simulator-mips.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parser.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/platform-cygwin.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-nullos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-openbsd.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-solaris.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/preparser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/runtime-profiler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime-profiler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/spaces.h View 6 chunks +10 lines, -10 lines 0 comments Download
M src/spaces.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M src/store-buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/store-buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/x64/assembler-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M src/x64/cpu-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-platform-win32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-sockets.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-spaces.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
8 years, 11 months ago (2012-01-12 10:16:07 UTC) #1
Kevin Millikin (Chromium)
LGTM. Is there a performance improvement?
8 years, 11 months ago (2012-01-13 11:44:33 UTC) #2
Erik Corry
8 years, 11 months ago (2012-01-13 13:38:36 UTC) #3
On 2012/01/13 11:44:33, Kevin Millikin wrote:
> LGTM.  Is there a performance improvement?

The expected performance improvements did not materialize, so I am doing another
iteration in the hope that it helps.


http://codereview.chromium.org/9123031

Powered by Google App Engine
This is Rietveld 408576698