Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 9130: scoped_cftyperef<>::reset() broken, bad mark! (Closed)

Created:
12 years, 1 month ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Amanda Walker
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Fix scoped_cftyperef<>::reset() to adopt the incoming CFTypeRef when the existing stored pointer is NULL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/scoped_cftyperef.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
12 years, 1 month ago (2008-11-04 20:17:22 UTC) #1
Amanda Walker
12 years, 1 month ago (2008-11-04 20:24:53 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698