Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2624)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/scoped_cftyperef.h

Issue 9130: scoped_cftyperef<>::reset() broken, bad mark! (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/scoped_cftyperef.h
===================================================================
--- base/scoped_cftyperef.h (revision 4630)
+++ base/scoped_cftyperef.h (working copy)
@@ -27,8 +27,9 @@
}
void reset(CFT object = NULL) {
- if (object_ && object_ != object) {
- CFRelease(object_);
+ if (object_ != object) {
+ if (object_)
+ CFRelease(object_);
object_ = object;
}
}
@@ -71,4 +72,3 @@
};
#endif // BASE_SCOPED_CFTYPEREF_H_
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698