Ignore Shift+Search when spoken feedback is enabled.

Ignore Shift+Search when spoken feedback is enabled.

This change depends on http://codereview.chromium.org/9225004/.

BUG=110127
TEST=manual, ran browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119523

[Zachary Kuznia, 2012-01-24 13:31:10]

lgtm

[dmazzoni, 2012-01-24 18:43:56]

http://codereview.chromium.org/9129016/diff/1/chrome/browser/ui/views/aura/ca...
File chrome/browser/ui/views/aura/caps_lock_handler.cc (right):

http://codereview.chromium.org/9129016/diff/1/chrome/browser/ui/views/aura/ca...
chrome/browser/ui/views/aura/caps_lock_handler.cc:47:
!g_browser_process->local_state()->GetBoolean(
This is great, but I'm afraid the next person who encounters this code won't
have any idea why it's here. How about like this:

if (is_running_on_chromeos_) {
  // When spoken feedback is enabled, the Search key is
  // used as an accessibility modifier key.
  if (g_browser_process->local_state()->GetBoolean(
      prefs::kSpokenFeedbackEnabled)) {
    return false;
  }

  ...
}

[dmazzoni, 2012-01-24 18:44:59]

lgtm

(no need to wait for another review, submit when ready)

[Yusuke Sato, 2012-01-25 01:43:16]

+ben (chrome/browser/ui/ owner)
Could you take a look?

http://codereview.chromium.org/9129016/diff/1/chrome/browser/ui/views/aura/ca...
File chrome/browser/ui/views/aura/caps_lock_handler.cc (right):

http://codereview.chromium.org/9129016/diff/1/chrome/browser/ui/views/aura/ca...
chrome/browser/ui/views/aura/caps_lock_handler.cc:47:
!g_browser_process->local_state()->GetBoolean(
On 2012/01/24 18:43:56, Dominic Mazzoni wrote:
> This is great, but I'm afraid the next person who encounters this code won't
> have any idea why it's here. How about like this:
> 
> if (is_running_on_chromeos_) {
>   // When spoken feedback is enabled, the Search key is
>   // used as an accessibility modifier key.
>   if (g_browser_process->local_state()->GetBoolean(
>       prefs::kSpokenFeedbackEnabled)) {
>     return false;
>   }
> 
>   ...
> }

Done.

[Ben Goodger (Google), 2012-01-26 16:32:27]

lgtm

[commit-bot: I haz the power, 2012-01-27 23:12:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9129016/5001