Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: chrome/browser/resources/uber/uber.html

Issue 9124028: separate about page into its own page (included in chrome://chrome) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/uber/uber.html
diff --git a/chrome/browser/resources/uber/uber.html b/chrome/browser/resources/uber/uber.html
index 7d382784daea24d7c2b0709aaa3d02db9c17dfaa..68ae7efbb6a43b0c906d0eff348bdca7c51b3a36 100644
--- a/chrome/browser/resources/uber/uber.html
+++ b/chrome/browser/resources/uber/uber.html
@@ -21,6 +21,9 @@
<ol>
<li class="selected" i18n-content="settingsDisplayName"></li>
<li i18n-content="extensionsDisplayName"></li>
+<if expr="pp_ifdef('chromeos')">
+ <li i18n-content="aboutPageDisplayName" id="aboutPageNavItem"></li>
+</if>
</ol>
</div>
@@ -32,6 +35,11 @@
<div class="iframe-container" i18n-values="id:extensionsHost">
<iframe src="chrome://extensions-frame/"></iframe></div>
+<if expr="pp_ifdef('chromeos')">
+ <div class="iframe-container" i18n-values="id:aboutPageHost">
+ <iframe src="chrome://about-page-frame/"></iframe></div>
Dan Beam 2012/01/09 23:05:51 Why isn't </div> on following line?
Evan Stade 2012/01/09 23:31:16 I haven't actually looked at an html style guide,
Dan Beam 2012/01/09 23:53:14 At first I thought there was no end </div> tag as
Evan Stade 2012/01/10 04:09:45 I dislike the idea of putting every closing tag on
+</if>
+
</body>
<script src="chrome://chrome/strings.js"></script>

Powered by Google App Engine
This is Rietveld 408576698