chrome/browser/resources/uber/uber.html - Issue 9124028: separate about page into its own page (included in chrome://chrome)

Side by Side Diff: chrome/browser/resources/uber/uber.html

Issue 9124028: separate about page into its own page (included in chrome://chrome) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/extensions/extensions.js ('K') | « chrome/browser/resources/uber/uber.css ('k') | chrome/browser/ui/webui/about_page/about_page_handler.h » ('j') | chrome/browser/ui/webui/about_page/about_page_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection;">	2 <html i18n-values="dir:textdirection;">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title i18n-content="pageTitle"></title>	5 <title i18n-content="pageTitle"></title>

6	6

7 <link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css">	7 <link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css">

8 <link rel="stylesheet" href="chrome://resources/css/open_sans.css">	8 <link rel="stylesheet" href="chrome://resources/css/open_sans.css">

9 <link rel="stylesheet" href="uber.css">	9 <link rel="stylesheet" href="uber.css">

10	10

11 <script src="chrome://resources/js/cr.js"></script>	11 <script src="chrome://resources/js/cr.js"></script>

12 <script src="chrome://resources/js/util.js"></script>	12 <script src="chrome://resources/js/util.js"></script>

13	13

14 <script src="chrome://chrome/uber.js"></script>	14 <script src="chrome://chrome/uber.js"></script>

15 </head>	15 </head>

16	16

17 <body>	17 <body>

18	18

19 <div id="navigation">	19 <div id="navigation">

20 <h3 i18n-content="shortProductName"></h3>	20 <h3 i18n-content="shortProductName"></h3>

21 <ol>	21 <ol>

22 <li class="selected" i18n-content="settingsDisplayName"></li>	22 <li class="selected" i18n-content="settingsDisplayName"></li>

23 <li i18n-content="extensionsDisplayName"></li>	23 <li i18n-content="extensionsDisplayName"></li>

	24 <if expr="pp_ifdef('chromeos')">

	25 <li i18n-content="aboutPageDisplayName" id="aboutPageNavItem"></li>

	26 </if>

24 </ol>	27 </ol>

25 </div>	28 </div>

26	29

27 <!-- The order of these must match the order of their nav controls.	30 <!-- The order of these must match the order of their nav controls.

28 The ID (e.g. "settings") doubles as the display pathname	31 The ID (e.g. "settings") doubles as the display pathname

29 (e.g. chrome://chrome/settings). -->	32 (e.g. chrome://chrome/settings). -->

30 <div class="iframe-container selected" i18n-values="id:settingsHost">	33 <div class="iframe-container selected" i18n-values="id:settingsHost">

31 <iframe src="chrome://settings-frame/"></iframe></div>	34 <iframe src="chrome://settings-frame/"></iframe></div>

32 <div class="iframe-container" i18n-values="id:extensionsHost">	35 <div class="iframe-container" i18n-values="id:extensionsHost">

33 <iframe src="chrome://extensions-frame/"></iframe></div>	36 <iframe src="chrome://extensions-frame/"></iframe></div>

34	37

	38 <if expr="pp_ifdef('chromeos')">

	39 <div class="iframe-container" i18n-values="id:aboutPageHost">

	40 <iframe src="chrome://about-page-frame/"></iframe></div>
	Dan Beam 2012/01/09 23:05:51 Why isn't </div> on following line? Why isn't </div> on following line? Evan Stade 2012/01/09 23:31:16 I haven't actually looked at an html style guide, Show quoted text On 2012/01/09 23:05:51, Dan Beam wrote: > Why isn't </div> on following line? I haven't actually looked at an html style guide, if one even exists, however I've seen this done a lot and I don't think it hurts readability. Do you? Dan Beam 2012/01/09 23:53:14 At first I thought there was no end </div> tag as Show quoted text On 2012/01/09 23:31:16, Evan Stade wrote: > On 2012/01/09 23:05:51, Dan Beam wrote: > > Why isn't </div> on following line? > > I haven't actually looked at an html style guide, if one even exists, however > I've seen this done a lot and I don't think it hurts readability. Do you? At first I thought there was no end </div> tag as it wasn't nested as I'm used to. Evan Stade 2012/01/10 04:09:45 I dislike the idea of putting every closing tag on Show quoted text On 2012/01/09 23:53:14, Dan Beam wrote: > On 2012/01/09 23:31:16, Evan Stade wrote: > > On 2012/01/09 23:05:51, Dan Beam wrote: > > > Why isn't </div> on following line? > > > > I haven't actually looked at an html style guide, if one even exists, however > > I've seen this done a lot and I don't think it hurts readability. Do you? > > At first I thought there was no end </div> tag as it wasn't nested as I'm used > to. I dislike the idea of putting every closing tag on a new line because that will lead to a lot of new lines. In our code, there is a lot of precedent for placing multiple end tags on the same line, and no style guide exists to contradict it, so I prefer to leave it this way.
	41 </if>

	42

35 </body>	43 </body>

36	44

37 <script src="chrome://chrome/strings.js"></script>	45 <script src="chrome://chrome/strings.js"></script>

38 <script src="chrome://resources/js/i18n_template.js"></script>	46 <script src="chrome://resources/js/i18n_template.js"></script>

39 <script src="chrome://resources/js/i18n_process.js"></script>	47 <script src="chrome://resources/js/i18n_process.js"></script>

40 </html>	48 </html>

OLD	NEW