add show_about_flag_aura_window_mode in common.gypi

This is added so that we can control from the chromeos build time whether to define this flag, and can optionally not add the aura-window-mode toggle to about://flags page.

BUG=109052
TEST=checked generated make file and compiles.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116964

[alicet1, 2012-01-07 01:18:47]

updated per discussion with dan. I don't have a sense on how/what to do it on
the chromeos side, dan can you help?

thanx,
alice

[Daniel Erat, 2012-01-07 01:23:14]

Ah, I misunderstood before -- I thought we were talking about adding a gyp flag
to control the default value of the about flag, rather than adding a gyp flag to
control whether the about flag is shown or not.

If we add this, we're still going to need another gyp flag later to control
which mode we use by default, right?

[James Cook, 2012-01-07 04:26:48]

I like the overall approach of a GYP flag, but is there a way to make it clearer
that this flag only applies to Aura builds and that the default is on?

http://codereview.chromium.org/9121002/diff/4002/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9121002/diff/4002/build/common.gypi#newcode49
build/common.gypi:49: # Default to show aura-window-mode flag in about://flags.
Maybe "Whether or not to show the aura-window-mode flag in about://flags"?  It's
a bit confusing that the default value here is 0, but this flag only applies to
Aura, and the flag defaults to 1 on Aura.

http://codereview.chromium.org/9121002/diff/4002/build/common.gypi#newcode52
build/common.gypi:52: 'show_about_flag_aura_window_mode': 0,
Maybe aura_show_about_flag_window_mode?  Or some other way to emphasize this
flag only applies if use_aura is true?

http://codereview.chromium.org/9121002/diff/4002/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/9121002/diff/4002/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:475: #if defined(USE_AURA) &&
defined(SHOW_ABOUT_FLAG_AURA_WINDOW_MODE)
Maybe this should be a single #if defined(AURA_SHOW_ABOUT_FLAG_WINDOW_MODE)?  Or
ENABLE_AURA_WINDOW_MODE?

[alicet1, 2012-01-09 08:52:11]

http://codereview.chromium.org/9121002/diff/4002/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/9121002/diff/4002/build/common.gypi#newcode49
build/common.gypi:49: # Default to show aura-window-mode flag in about://flags.
On 2012/01/07 04:26:48, James Cook (Chromium) wrote:
> Maybe "Whether or not to show the aura-window-mode flag in about://flags"? 
It's
> a bit confusing that the default value here is 0, but this flag only applies
to
> Aura, and the flag defaults to 1 on Aura.

done.

http://codereview.chromium.org/9121002/diff/4002/build/common.gypi#newcode52
build/common.gypi:52: 'show_about_flag_aura_window_mode': 0,
On 2012/01/07 04:26:48, James Cook (Chromium) wrote:
> Maybe aura_show_about_flag_window_mode?  Or some other way to emphasize this
> flag only applies if use_aura is true?

Done.

http://codereview.chromium.org/9121002/diff/4002/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/9121002/diff/4002/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:475: #if defined(USE_AURA) &&
defined(SHOW_ABOUT_FLAG_AURA_WINDOW_MODE)
On 2012/01/07 04:26:48, James Cook (Chromium) wrote:
> Maybe this should be a single #if defined(AURA_SHOW_ABOUT_FLAG_WINDOW_MODE)? 
Or
> ENABLE_AURA_WINDOW_MODE?

Done.

[Daniel Erat, 2012-01-09 16:00:18]

lgtm

[James Cook, 2012-01-09 16:19:53]

lgtm

[commit-bot: I haz the power, 2012-01-09 22:54:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alicet@chromium.org/9121002/14001

[commit-bot: I haz the power, 2012-01-10 00:13:40]

Change committed as 116964