add show_about_flag_aura_window_mode in common.gypi

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 27 matching lines @@
 
           # Use OpenSSL instead of NSS. Under development: see http://crbug.com/62803
           'use_openssl%': 0,
 
           # Disable Virtual keyboard support by default.
           'use_virtual_keyboard%': 0,
 
           # Default setting for use_skia on mac platform.
           # This is typically overridden in use_skia_on_mac.gypi.
           'use_skia_on_mac%': 0,
+
+          # Default to show aura-window-mode flag in about://flags.

[James Cook, 2012/01/07 04:26:48]

Maybe "Whether or not to show the aura-window-mode flag in about://flags"?  It's
a bit confusing that the default value here is 0, but this flag only applies to
Aura, and the flag defaults to 1 on Aura.

[alicet1, 2012/01/09 08:52:16]

done.

+          # TODO(alicet): Remove this when we can expose the flag to
+          # all chromeos platforms.
+          'show_about_flag_aura_window_mode': 0,

[James Cook, 2012/01/07 04:26:48]

Maybe aura_show_about_flag_window_mode?  Or some other way to emphasize this
flag only applies if use_aura is true?

[alicet1, 2012/01/09 08:52:16]

Done.

         },
         # Copy conditionally-set variables out one scope.
         'chromeos%': '<(chromeos)',
+        'show_about_flag_aura_window_mode%': '<(show_about_flag_aura_window_mode)',
         'views_compositor%': '<(views_compositor)',
         'use_aura%': '<(use_aura)',
         'use_ash%': '<(use_ash)',
         'use_openssl%': '<(use_openssl)',
         'use_virtual_keyboard%': '<(use_virtual_keyboard)',
         'use_skia_on_mac%': '<(use_skia_on_mac)',
 
         # Compute the architecture that we're building on.
         'conditions': [
           [ 'OS=="win" or OS=="mac"', {
             'host_arch%': 'ia32',
           }, {
             # This handles the Unix platforms for which there is some support.
             # Anything else gets passed through, which probably won't work very
             # well; such hosts should pass an explicit target_arch to gyp.
             'host_arch%':
               '<!(uname -m | sed -e "s/i.86/ia32/;s/x86_64/x64/;s/amd64/x64/;s/arm.*/arm/;s/i86pc/ia32/")',
           }],
           
           # Ash requires Aura.
           ['use_ash==1', {
             'use_aura%': 1,
           }],
 
+          # show aura-window-mode about flag by default.
+          ['use_aura==1', {
+            'show_about_flag_aura_window_mode': 1,
+          }],
+
           # Set default value of toolkit_views based on OS.
           ['OS=="win" or chromeos==1 or use_aura==1', {
             'toolkit_views%': 1,
           }, {
             'toolkit_views%': 0,
           }],
 
           # Use the views compositor when using the Aura window manager.
           ['use_aura==1', {
             'views_compositor%': 1,
           }],
 
           # Use the WebKit compositor for ui, when Aura is on.
           ['use_aura==1', {
             'use_webkit_compositor%': 1,
           }, {
             'use_webkit_compositor%': 0,
           }],
         ],
       },
 
       # Copy conditionally-set variables out one scope.
       'chromeos%': '<(chromeos)',
       'host_arch%': '<(host_arch)',
+      'show_about_flag_aura_window_mode%': '<(show_about_flag_aura_window_mode)',
       'toolkit_views%': '<(toolkit_views)',
       'views_compositor%': '<(views_compositor)',
       'use_webkit_compositor%': '<(use_webkit_compositor)',
       'use_aura%': '<(use_aura)',
       'use_ash%': '<(use_ash)',
       'use_openssl%': '<(use_openssl)',
       'use_virtual_keyboard%': '<(use_virtual_keyboard)',
       'use_skia_on_mac%': '<(use_skia_on_mac)',
 
       # We used to provide a variable for changing how libraries were built.
@@ skipping 246 matching lines @@
         }],
       ],
     },
 
     # Copy conditionally-set variables out one scope.
     'branding%': '<(branding)',
     'buildtype%': '<(buildtype)',
     'target_arch%': '<(target_arch)',
     'host_arch%': '<(host_arch)',
     'library%': 'static_library',
+    'show_about_flag_aura_window_mode%': '<(show_about_flag_aura_window_mode)',
     'toolkit_views%': '<(toolkit_views)',
     'views_compositor%': '<(views_compositor)',
     'ui_compositor_image_transport%': '<(ui_compositor_image_transport)',
     'use_webkit_compositor%': '<(use_webkit_compositor)',
     'use_aura%': '<(use_aura)',
     'use_ash%': '<(use_ash)',
     'use_openssl%': '<(use_openssl)',
     'use_nss%': '<(use_nss)',
     'os_bsd%': '<(os_bsd)',
     'os_posix%': '<(os_posix)',
@@ skipping 458 matching lines @@
         # consistency they should look for google_chrome_build like C++.
         'grit_defines': ['-D', '_google_chrome',
                          '-E', 'CHROMIUM_BUILD=google_chrome'],
       }, {
         'grit_defines': ['-D', '_chromium',
                          '-E', 'CHROMIUM_BUILD=chromium'],
       }],
       ['chromeos==1', {
         'grit_defines': ['-D', 'chromeos'],
       }],
+      ['show_about_flag_aura_window_mode==1', {
+        'grit_defines': ['-D', 'show_about_flag_aura_window_mode'],
+      }],
       ['toolkit_views==1', {
         'grit_defines': ['-D', 'toolkit_views'],
       }],
       ['use_aura==1', {
         'grit_defines': ['-D', 'use_aura'],
       }],
       ['use_ash==1', {
         'grit_defines': ['-D', 'use_ash'],
       }],
       ['use_nss==1', {
@@ skipping 148 matching lines @@
         'defines': ['COMPONENT_BUILD'],
       }],
       ['component=="shared_library" and incremental_chrome_dll==1', {
         # TODO(dpranke): We can't incrementally link chrome when
         # content is being built as a DLL because chrome links in
         # webkit_glue and webkit_glue depends on symbols defined in
         # content. We can remove this when we fix glue.
         # See http://code.google.com/p/chromium/issues/detail?id=98755 .
         'defines': ['COMPILE_CONTENT_STATICALLY'],
       }],
+      ['show_about_flag_aura_window_mode==1', {
+        'defines': ['SHOW_ABOUT_FLAG_AURA_WINDOW_MODE=1'],
+      }],
       ['toolkit_views==1', {
         'defines': ['TOOLKIT_VIEWS=1'],
       }],
       ['views_compositor==1', {
         'defines': ['VIEWS_COMPOSITOR=1'],
       }],
       ['ui_compositor_image_transport==1', {
         'defines': ['UI_COMPOSITOR_IMAGE_TRANSPORT'],
       }],
       ['use_webkit_compositor==1', {
@@ skipping 1759 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }