Make ssh compatible with dev mode and remove testing ssh items that don't work

Make ssh compatible with dev mode and remove testing ssh items that don't work

[gauravsh, 2010-03-12 21:59:44]

LGTM

http://codereview.chromium.org/912003/diff/1/2
File src/platform/init/openssh-server.conf (right):

http://codereview.chromium.org/912003/diff/1/2#newcode7
src/platform/init/openssh-server.conf:7: start on stopped dump-boot-stats
Any specific reason for starting this late? (I am assuming dump-boot-stats is
one of the last things that's run)

[sosa, 2010-03-12 22:01:32]

http://codereview.chromium.org/912003/diff/1/2
File src/platform/init/openssh-server.conf (right):

http://codereview.chromium.org/912003/diff/1/2#newcode7
src/platform/init/openssh-server.conf:7: start on stopped dump-boot-stats
Ssh server is a development mode specific upstart job and shouldn't get in the
way of the core system starting up (affects perf metrics etc).  Since it's not a
core script it should be delayed.  

On 2010/03/12 21:59:45, gauravsh wrote:
> Any specific reason for starting this late? (I am assuming dump-boot-stats is
> one of the last things that's run)

[gauravsh, 2010-03-12 22:15:58]

On Fri, Mar 12, 2010 at 2:01 PM,  <sosa@chromium.org> wrote:
>
> http://codereview.chromium.org/912003/diff/1/2
> File src/platform/init/openssh-server.conf (right):
>
> http://codereview.chromium.org/912003/diff/1/2#newcode7
> src/platform/init/openssh-server.conf:7: start on stopped
> dump-boot-stats
> Ssh server is a development mode specific upstart job and shouldn't get
> in the way of the core system starting up (affects perf metrics etc).
> Since it's not a core script it should be delayed.

Ahh yes, makes sense.

>
> On 2010/03/12 21:59:45, gauravsh wrote:
>>
>> Any specific reason for starting this late? (I am assuming
>
> dump-boot-stats is
>>
>> one of the last things that's run)
>
> http://codereview.chromium.org/912003
>



-- 
-g

[ericli, 2010-03-12 23:15:55]

How this will affect an official build? no ssh there any more?

On Fri, Mar 12, 2010 at 2:15 PM, Gaurav Shah <gauravsh@chromium.org> wrote:

> On Fri, Mar 12, 2010 at 2:01 PM,  <sosa@chromium.org> wrote:
> >
> > http://codereview.chromium.org/912003/diff/1/2
> > File src/platform/init/openssh-server.conf (right):
> >
> > http://codereview.chromium.org/912003/diff/1/2#newcode7
> > src/platform/init/openssh-server.conf:7: start on stopped
> > dump-boot-stats
> > Ssh server is a development mode specific upstart job and shouldn't get
> > in the way of the core system starting up (affects perf metrics etc).
> > Since it's not a core script it should be delayed.
>
> Ahh yes, makes sense.
>
> >
> > On 2010/03/12 21:59:45, gauravsh wrote:
> >>
> >> Any specific reason for starting this late? (I am assuming
> >
> > dump-boot-stats is
> >>
> >> one of the last things that's run)
> >
> > http://codereview.chromium.org/912003
> >
>
>
>
> --
> -g
>



-- 
Eric Li
李咏竹
Google Kirkland