Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 9120017: modified New Application Wizard to allow for generation of web/command line application (Closed)

Created:
8 years, 11 months ago by keertip
Modified:
8 years, 11 months ago
Reviewers:
messick, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

modified New Application Wizard to allow for generation of web/command line application Committed: https://code.google.com/p/dart/source/detail?r=3104

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages

Total messages: 5 (0 generated)
keertip
8 years, 11 months ago (2012-01-06 23:16:46 UTC) #1
messick
lgtm Just one request to look into, and it may be optional. http://codereview.chromium.org/9120017/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/generated-dart-server.txt File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/generated-dart-server.txt ...
8 years, 11 months ago (2012-01-07 01:47:35 UTC) #2
danrubel
lgtm
8 years, 11 months ago (2012-01-07 14:42:22 UTC) #3
messick
http://codereview.chromium.org/9120017/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/wizard/WizardMessages.properties File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/wizard/WizardMessages.properties (right): http://codereview.chromium.org/9120017/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/wizard/WizardMessages.properties#newcode4 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/wizard/WizardMessages.properties:4: NewApplicationWizardPage_CommandLineApplication=Command Line This should be "Script" instead of "Command ...
8 years, 11 months ago (2012-01-09 13:37:30 UTC) #4
keertip
8 years, 11 months ago (2012-01-09 17:15:03 UTC) #5
http://codereview.chromium.org/9120017/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/wizard/WizardMessages.properties
(right):

http://codereview.chromium.org/9120017/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/wizard/WizardMessages.properties:4:
NewApplicationWizardPage_CommandLineApplication=Command Line
On 2012/01/09 13:37:30, messick wrote:
> This should be "Script" instead of "Command Line" and both it and the web app
> button should have hover text. For the Web app button: "Create a web client
that
> runs in the browser." For the script button: "Create a command-line script."

Done.

Powered by Google App Engine
This is Rietveld 408576698