Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: runtime/lib/date.cc

Issue 9114054: Port a couple more stubs to x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/integers.cc » ('j') | runtime/lib/integers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/date.cc
===================================================================
--- runtime/lib/date.cc (revision 3226)
+++ runtime/lib/date.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -40,7 +40,8 @@
intptr_t year = smi_years.Value() - 1900;
// TODO(floitsch): We don't handle the case yet where intptr_t and int have
// different sizes.
- ASSERT(sizeof(year) <= sizeof(broken_down.year));
+ // See issue 1143.
Ivan Posva 2012/01/12 22:27:31 How about changing the TODO above to TODO(1143) in
regis 2012/01/12 22:53:37 Done. Also added a static cast to make the convers
+ // ASSERT(sizeof(year) <= sizeof(broken_down.year));
broken_down.year = year;
// libc months are 0-based (contrary to Dart' 1-based months).
broken_down.month = dart_month.Value() - 1;
« no previous file with comments | « no previous file | runtime/lib/integers.cc » ('j') | runtime/lib/integers.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698