Port a couple more stubs to x64.

runtime/lib/date.cc

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/os.h"
 
@@ skipping 21 matching lines @@
     UNIMPLEMENTED();
   }
   Smi& smi_years = Smi::Handle();
   smi_years ^= dart_years.raw();
   OS::BrokenDownDate broken_down;
   // mktime takes the years since 1900.
   // TODO(floitsch): Removing 1900 could underflow the intptr_t.
   intptr_t year = smi_years.Value() - 1900;
   // TODO(floitsch): We don't handle the case yet where intptr_t and int have
   // different sizes.
-  ASSERT(sizeof(year) <= sizeof(broken_down.year));
+  // See issue 1143.

[Ivan Posva, 2012/01/12 22:27:31]

How about changing the TODO above to TODO(1143) instead?

[regis, 2012/01/12 22:53:37]

Done. Also added a static cast to make the conversion explicit.

+  // ASSERT(sizeof(year) <= sizeof(broken_down.year));
   broken_down.year = year;
   // libc months are 0-based (contrary to Dart' 1-based months).
   broken_down.month = dart_month.Value() - 1;
   broken_down.day = dart_day.Value();
   broken_down.hours = dart_hours.Value();
   broken_down.minutes = dart_minutes.Value();
   broken_down.seconds = dart_seconds.Value();
   time_t value;
   bool succeeded = OS::BrokenDownToSecondsSinceEpoch(broken_down,
                                                      dart_is_utc.value(),
@@ skipping 92 matching lines @@
   bool succeeded =
       BreakDownSecondsSinceEpoch(dart_seconds, dart_is_utc, &broken_down);
   if (!succeeded) {
     UNIMPLEMENTED();
   }
   const Smi& result = Smi::Handle(Smi::New(broken_down.seconds));
   arguments->SetReturn(result);
 }
 
 }  // namespace dart