Chromium Code Reviews| Index: runtime/lib/date.cc |
| =================================================================== |
| --- runtime/lib/date.cc (revision 3226) |
| +++ runtime/lib/date.cc (working copy) |
| @@ -1,4 +1,4 @@ |
| -// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file |
| +// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
| // for details. All rights reserved. Use of this source code is governed by a |
| // BSD-style license that can be found in the LICENSE file. |
| @@ -40,7 +40,8 @@ |
| intptr_t year = smi_years.Value() - 1900; |
| // TODO(floitsch): We don't handle the case yet where intptr_t and int have |
| // different sizes. |
| - ASSERT(sizeof(year) <= sizeof(broken_down.year)); |
| + // See issue 1143. |
|
Ivan Posva
2012/01/12 22:27:31
How about changing the TODO above to TODO(1143) in
regis
2012/01/12 22:53:37
Done. Also added a static cast to make the convers
|
| + // ASSERT(sizeof(year) <= sizeof(broken_down.year)); |
| broken_down.year = year; |
| // libc months are 0-based (contrary to Dart' 1-based months). |
| broken_down.month = dart_month.Value() - 1; |