Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 9114038: Fix for an ARM register allocation bug. (Closed)

Created:
8 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix for an ARM register allocation bug. An off-by-one in the register allocator could lead to allocating (and clobbering) the reserved 0.0 double register. This required a function with 14 or more live double values. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10374

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix bug in ARM gap resolver. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M src/arm/assembler-arm.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 1 6 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kevin Millikin (Chromium)
Slava, would you please take a look at this?
8 years, 11 months ago (2012-01-10 15:24:38 UTC) #1
Vyacheslav Egorov (Chromium)
lgtm please add a test in a separate revision also please when transitioning from js ...
8 years, 11 months ago (2012-01-10 15:28:27 UTC) #2
Kevin Millikin (Chromium)
The ARM gap resolver had a hard coded r0 as an available scratch register. This ...
8 years, 11 months ago (2012-01-10 16:15:03 UTC) #3
Kevin Millikin (Chromium)
Redirecting to fschneider.
8 years, 11 months ago (2012-01-10 16:52:57 UTC) #4
fschneider
8 years, 11 months ago (2012-01-10 16:59:05 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698