Added method map to Collection interface and all its implementations (except classes generated fr...

client/html/src/ElementWrappingImplementation.dart

Index: client/html/src/ElementWrappingImplementation.dart
===================================================================
--- client/html/src/ElementWrappingImplementation.dart	(revision 2973)
+++ client/html/src/ElementWrappingImplementation.dart	(working copy)
@@ -30,6 +30,14 @@
     }
   }
 
+  Collection map(f(Element element)) {
+    List<Element> output = new List<Element>();

[Jennifer Messerly, 2012/01/05 22:54:21]

Is this right? It seems like the type should be List, e.g.:
    List output = [];

+    forEach((Element element) {
+        output.add(f(element));

[Jennifer Messerly, 2012/01/05 22:54:21]

nit: indent -2

+    });
+    return output;
+  }
+
   Collection<Element> filter(bool f(Element element)) {
     List<Element> output = new List<Element>();
     forEach((Element element) {
@@ -160,6 +168,10 @@
     }
   }
 
+  Collection map(f(Element element)) {
+    throw 'Not impl yet. todo(jacobr)';

[ahe, 2012/01/05 22:36:54]

Please don't abbreviate and follow TODO conventions:

// TODO(jacobr): Implement this.
throw 'not implemented yet';

[Jennifer Messerly, 2012/01/05 22:54:21]

could also be "throw const NotImplementedException();" ?

(although now that I look further down, it seems like the existing code was
throwing strings too.)

+  }
+
   Collection<Element> filter(bool f(Element element)) {
     throw 'Not impl yet. todo(jacobr)';
   }