Added method map to Collection interface and all its implementations (except classes generated fr...

client/html/src/ElementWrappingImplementation.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(jacobr): use Lists.dart to remove some of the duplicated functionality.
 class _ChildrenElementList implements ElementList {
   // Raw Element.
   final _element;
   final _childElements;
 
@@ skipping 12 matching lines @@
   Element get first() {
     return LevelDom.wrapElement(_element.firstElementChild);
   }
 
   void forEach(void f(Element element)) {
     for (var element in _childElements) {
       f(LevelDom.wrapElement(element));
     }
   }
 
+  Collection map(f(Element element)) {
+    List<Element> output = new List<Element>();

[Jennifer Messerly, 2012/01/05 22:54:21]

Is this right? It seems like the type should be List, e.g.:
    List output = [];

+    forEach((Element element) {
+        output.add(f(element));

[Jennifer Messerly, 2012/01/05 22:54:21]

nit: indent -2

+    });
+    return output;
+  }
+
   Collection<Element> filter(bool f(Element element)) {
     List<Element> output = new List<Element>();
     forEach((Element element) {
       if (f(element)) {
         output.add(element);
       }
     });
     return output;
   }
 
@@ skipping 110 matching lines @@
   Element get first() {
     return this[0];
   }
 
   void forEach(void f(Element element)) {
     for (var element in _ptr) {
       f(LevelDom.wrapElement(element));
     }
   }
 
+  Collection map(f(Element element)) {
+    throw 'Not impl yet. todo(jacobr)';

[ahe, 2012/01/05 22:36:54]

Please don't abbreviate and follow TODO conventions:

// TODO(jacobr): Implement this.
throw 'not implemented yet';

[Jennifer Messerly, 2012/01/05 22:54:21]

could also be "throw const NotImplementedException();" ?

(although now that I look further down, it seems like the existing code was
throwing strings too.)

+  }
+
   Collection<Element> filter(bool f(Element element)) {
     throw 'Not impl yet. todo(jacobr)';
   }
 
   bool every(bool f(Element element)) {
     throw 'Not impl yet. todo(jacobr)';
   }
 
   bool some(bool f(Element element)) {
     throw 'Not impl yet. todo(jacobr)';
@@ skipping 585 matching lines @@
         new Completer<CSSStyleDeclaration>());
   }
 
   ElementEvents get on() {
     if (_on === null) {
       _on = new ElementEventsImplementation._wrap(_ptr);
     }
     return _on;
   }
 }