Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3896)

Unified Diff: buildbot/status/web/base.py

Issue 9113086: Add " (CQ)" to the author name in the console if the commit-queue was used. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/build/third_party/buildbot_8_4p1/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: buildbot/status/web/base.py
===================================================================
--- buildbot/status/web/base.py (revision 113419)
+++ buildbot/status/web/base.py (working copy)
@@ -498,6 +498,7 @@
urlencode = urllib.quote,
email = emailfilter,
user = userfilter,
+ cq = cqfilter,
M-A Ruel 2012/01/26 18:53:47 An option is to monkey patch it in scripts/master/
sadrul 2012/01/26 20:24:41 Interesting idea! I have made that change.
shortrev = shortrevfilter(revlink, env),
revlink = revlinkfilter(revlink, env),
changecomment = changelinkfilter(changecommentlink),
@@ -533,7 +534,15 @@
return jinja2.Markup('<div class="user">%s<div class="email">%s</div></div>' % (user, email))
else:
return emailfilter(value) # filter for emails here for safety
-
+
+def cqfilter(value):
+ ''' Adds a helpful '(CQ)' to make it visibly obvious which commits were made
+ through the commit queue.
+'''
+ if value:
sadrul 2012/01/26 17:57:49 I am assuming |value| here will continue to be a b
M-A Ruel 2012/01/26 18:53:47 :/ No idea.
+ return " (CQ)"
+ return ""
+
def _revlinkcfg(replace, templates):
'''Helper function that returns suitable macros and functions
for building revision links depending on replacement mechanism

Powered by Google App Engine
This is Rietveld 408576698