Add " (CQ)" to the author name in the console if the commit-queue was used.

Add " (CQ)" to the author name in the console if the commit-queue was used.


BUG=106658

[sadrul, 2012-01-26 17:57:49]

Hi! Second attempt from http://codereview.chromium.org/8835004/

http://codereview.chromium.org/9113086/diff/1/buildbot/changes/svnpoller.py
File buildbot/changes/svnpoller.py (right):

http://codereview.chromium.org/9113086/diff/1/buildbot/changes/svnpoller.py#n...
buildbot/changes/svnpoller.py:206: "--with-all-revprops"])
You suggested in the previous CL for this that this should be moved to
scripts/master/. I see that SVNPoller is subclassed in
scripts/master/try_job_svn.py. If I understand this right, I should do something
similar (in chromium_svnpoller.py?). I am not sure what else I should change to
make sure the subclass'ed SVNPoller is used. So for now, I have kept this change
here.

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/base.py
File buildbot/status/web/base.py (right):

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/base.py#new...
buildbot/status/web/base.py:542: if value:
I am assuming |value| here will continue to be a boolean, and not a string. Is
this assumption correct?

[M-A Ruel, 2012-01-26 18:53:46]

http://codereview.chromium.org/9113086/diff/1/buildbot/changes/svnpoller.py
File buildbot/changes/svnpoller.py (right):

http://codereview.chromium.org/9113086/diff/1/buildbot/changes/svnpoller.py#n...
buildbot/changes/svnpoller.py:206: "--with-all-revprops"])
On 2012/01/26 17:57:49, sadrul wrote:
> You suggested in the previous CL for this that this should be moved to
> scripts/master/. I see that SVNPoller is subclassed in
> scripts/master/try_job_svn.py. If I understand this right, I should do
something
> similar (in chromium_svnpoller.py?). I am not sure what else I should change
to
> make sure the subclass'ed SVNPoller is used. So for now, I have kept this
change
> here.

Yes, I want you to do the same thing that what is done with try_job_svn.py. Then
you can use the subclassed class in each master.cfg. This way, we can start with
master.chromium.fyi/master.cfg first and once it's determined to work, we can
enable all the other masters.

So in short;
In master.cfg, instead of "from buildbot.changes import svnpoller", use "from
master import svnpoller"

Then in scripts/master/svnpoller.py:

class SVNPoller(svnpoller.SVNPoller):
  def get_logs(self, _):
    args = ["log", "--xml", "--verbose", "--non-interactive",
"--with-all-revprops"]
(...)
  def create_changes(self, new_logentries):
(...)

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/base.py
File buildbot/status/web/base.py (right):

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/base.py#new...
buildbot/status/web/base.py:501: cq = cqfilter,
An option is to monkey patch it in scripts/master/chromium_status_bb8.py, e.g.

def MonkeyPatch():
  from buildbot.status.web import base
  x = base.createJinjaEnv
  def new(*args, **kwargs):
    out = x(*args, **kwargs)
    out.filters.update({'cq': cqfilter})
    return out
  base.createJinjaEnv = new

(with better names)

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/base.py#new...
buildbot/status/web/base.py:542: if value:
On 2012/01/26 17:57:49, sadrul wrote:
> I am assuming |value| here will continue to be a boolean, and not a string. Is
> this assumption correct?

:/ No idea.

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/templates/c...
File buildbot/status/web/templates/console.html (right):

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/templates/c...
buildbot/status/web/templates/console.html:190: {{ r.cq|cq }}
Argh, it's a shame that
third_party/buildbot_8_4p1/buildbot/status/web/console.py line 809 doesn't use a
variable so we could change it easily.

So keep the patch there but add it to README.chromium.

[sadrul, 2012-01-26 20:24:41]

Thanks a lot for the suggestions! As per your suggestions, I have moved the
svnpoller changes in scripts/master/, updated README.chromium. I also changed a
little so we won't need the cqfilter anymore. Since I had to change the base URL
so I could include all these changes in one CL, I have created a new one:
http://codereview.chromium.org/9169097/

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/base.py
File buildbot/status/web/base.py (right):

http://codereview.chromium.org/9113086/diff/1/buildbot/status/web/base.py#new...
buildbot/status/web/base.py:501: cq = cqfilter,
On 2012/01/26 18:53:47, Marc-Antoine Ruel wrote:
> An option is to monkey patch it in scripts/master/chromium_status_bb8.py, e.g.
> 
> def MonkeyPatch():
>   from buildbot.status.web import base
>   x = base.createJinjaEnv
>   def new(*args, **kwargs):
>     out = x(*args, **kwargs)
>     out.filters.update({'cq': cqfilter})
>     return out
>   base.createJinjaEnv = new
> 
> (with better names)

Interesting idea! I have made that change.