Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3208)

Unified Diff: buildbot/changes/svnpoller.py

Issue 9113086: Add " (CQ)" to the author name in the console if the commit-queue was used. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/build/third_party/buildbot_8_4p1/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | buildbot/status/web/base.py » ('j') | buildbot/status/web/base.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/changes/svnpoller.py
===================================================================
--- buildbot/changes/svnpoller.py (revision 113419)
+++ buildbot/changes/svnpoller.py (working copy)
@@ -202,7 +202,8 @@
def get_logs(self, _):
args = []
- args.extend(["log", "--xml", "--verbose", "--non-interactive"])
+ args.extend(["log", "--xml", "--verbose", "--non-interactive",
+ "--with-all-revprops"])
sadrul 2012/01/26 17:57:49 You suggested in the previous CL for this that thi
M-A Ruel 2012/01/26 18:53:47 Yes, I want you to do the same thing that what is
if self.svnuser:
args.extend(["--username=%s" % self.svnuser])
if self.svnpasswd:
@@ -289,6 +290,14 @@
def create_changes(self, new_logentries):
changes = []
+ def commit_bot_used(logentry):
+ revprops = logentry.getElementsByTagName('revprops')
+ if revprops is not None:
+ for revprop in revprops.getElementsByTagName('property'):
+ if revprop.getAttribute("name") == "commit-bot":
+ return True
+ return False
+
for el in new_logentries:
revision = str(el.getAttribute("revision"))
@@ -301,6 +310,7 @@
log.msg("Adding change revision %s" % (revision,))
author = self._get_text(el, "author")
comments = self._get_text(el, "msg")
+ used_cq = commit_bot_used(el)
# there is a "date" field, but it provides localtime in the
# repository's timezone, whereas we care about buildmaster's
# localtime (since this will get used to position the boxes on
@@ -346,6 +356,7 @@
else:
chdict = dict(
who=author,
+ cq=used_cq,
files=files,
comments=comments,
revision=revision,
« no previous file with comments | « no previous file | buildbot/status/web/base.py » ('j') | buildbot/status/web/base.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698