Issue 9113056: Change the launcher to use AccessiblePaneView, and make the buttons focusable

Issue 9113056: Change the launcher to use AccessiblePaneView, and make the buttons focusable (Closed)

Created:
8 years, 11 months ago by Zachary Kuznia

Modified:
8 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change the launcher to use AccessiblePaneView, and make the buttons focusable R=sky@chromium.org BUG=104192 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119204

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
M	ash/launcher/app_launcher_button.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/launcher/launcher.cc	View		3 chunks	+12 lines, -1 line	0 comments	Download
M	ash/launcher/launcher_view.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/launcher/tabbed_launcher_button.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

sky

Make overflow_button_ in LauncherView focusable too, and this LGTM

8 years, 11 months ago (2012-01-25 15:27:29 UTC) #2

Zachary Kuznia

On 2012/01/25 15:27:29, sky wrote: > Make overflow_button_ in LauncherView focusable too, and this LGTM ...

8 years, 11 months ago (2012-01-26 02:33:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/9113056/3001

8 years, 11 months ago (2012-01-26 02:33:37 UTC) #4

commit-bot: I haz the power

Try job failure for 9113056-3001 (retry) on win_rel for step "base_unittests". It's a second try, ...

8 years, 11 months ago (2012-01-26 05:01:50 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/9113056/3001

8 years, 11 months ago (2012-01-26 05:20:28 UTC) #6

Change committed as 119204