Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9111032: Change over IgnoreReturn to IgnoreResult. remove IgnoreReturn. (Closed)

Created:
8 years, 11 months ago by awong
Modified:
8 years, 11 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, vrk (LEFT CHROMIUM), nkostylev+watch_chromium.org, acolwell+watch_chromium.org, amit, annacc+watch_chromium.org, rginda+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, kkania, ihf+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, pam+watch_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, achuith+watch_chromium.org, robertshield, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change over IgnoreReturn to IgnoreResult. remove IgnoreReturn. BUG=98919 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116631

Patch Set 1 #

Patch Set 2 : Fix minor errors #

Total comments: 1

Patch Set 3 : Fix linux #

Patch Set 4 : fix it for realz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -347 lines) Patch
M base/bind_helpers.h View 1 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/automation/automation_provider_gtk.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/customization_document.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/history/shortcuts_backend.cc View 5 chunks +18 lines, -12 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x_unittest.cc View 1 20 chunks +117 lines, -107 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 1 2 3 19 chunks +124 lines, -104 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/platform_util_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/rlz/rlz.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome_frame/crash_reporting/nt_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/vtable_patch_manager_unittest.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M content/browser/browser_message_filter.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/utility_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/audio_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
awong
This ends up getting in the way of removing task.h so I had to do ...
8 years, 11 months ago (2012-01-05 23:13:00 UTC) #1
James Hawkins
LGTM http://codereview.chromium.org/9111032/diff/6001/chrome/browser/profiles/profile_manager_unittest.cc File chrome/browser/profiles/profile_manager_unittest.cc (right): http://codereview.chromium.org/9111032/diff/6001/chrome/browser/profiles/profile_manager_unittest.cc#newcode70 chrome/browser/profiles/profile_manager_unittest.cc:70: base::Bind(base::IgnoreResult(&file_util::CreateDirectory), path)); Hmm seems strange this works but ...
8 years, 11 months ago (2012-01-05 23:16:25 UTC) #2
awong
On 2012/01/05 23:16:25, James Hawkins wrote: > LGTM > > http://codereview.chromium.org/9111032/diff/6001/chrome/browser/profiles/profile_manager_unittest.cc > File chrome/browser/profiles/profile_manager_unittest.cc (right): ...
8 years, 11 months ago (2012-01-05 23:28:26 UTC) #3
awong
8 years, 11 months ago (2012-01-06 00:58:15 UTC) #4 
On 2012/01/05 23:28:26, awong wrote:
> On 2012/01/05 23:16:25, James Hawkins wrote:
> > LGTM
> > 
> >
>
http://codereview.chromium.org/9111032/diff/6001/chrome/browser/profiles/prof...
> > File chrome/browser/profiles/profile_manager_unittest.cc (right):
> > 
> >
>
http://codereview.chromium.org/9111032/diff/6001/chrome/browser/profiles/prof...
> > chrome/browser/profiles/profile_manager_unittest.cc:70:
> > base::Bind(base::IgnoreResult(&file_util::CreateDirectory), path));
> > Hmm seems strange this works but the previous file in the CL needs the
wrapper
> > :-/
> 
> The try servers still haven't said it works yet. :)

And...win_rel passed. Strange.

Powered by Google App Engine
This is Rietveld 408576698