Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Side by Side Diff: chrome_frame/chrome_frame_automation.cc

Issue 9111032: Change over IgnoreReturn to IgnoreResult. remove IgnoreReturn. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix it for realz Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome_frame/cfproxy_test.cc ('k') | chrome_frame/crash_reporting/nt_loader_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome_frame/chrome_frame_automation.h" 5 #include "chrome_frame/chrome_frame_automation.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 971 matching lines...) Expand 10 before | Expand all | Expand 10 after
982 if (ui_thread || (url_fetcher_flags_ & 982 if (ui_thread || (url_fetcher_flags_ &
983 PluginUrlRequestManager::COOKIE_REQUEST_THREADSAFE)) { 983 PluginUrlRequestManager::COOKIE_REQUEST_THREADSAFE)) {
984 AutomationMsg_SetCookieAsync::Dispatch(&msg, url_fetcher_, this, 984 AutomationMsg_SetCookieAsync::Dispatch(&msg, url_fetcher_, this,
985 &PluginUrlRequestManager::SetCookiesInHost); 985 &PluginUrlRequestManager::SetCookiesInHost);
986 return true; 986 return true;
987 } 987 }
988 break; 988 break;
989 } 989 }
990 990
991 PostTask( 991 PostTask(
992 FROM_HERE, base::IgnoreReturn<bool>(base::Bind( 992 FROM_HERE,
993 &ChromeFrameAutomationClient::ProcessUrlRequestMessage, 993 base::Bind(
994 base::Unretained(this), tab, msg, true))); 994 base::IgnoreResult(
995 &ChromeFrameAutomationClient::ProcessUrlRequestMessage),
996 base::Unretained(this), tab, msg, true));
995 return true; 997 return true;
996 } 998 }
997 999
998 // These are invoked in channel's background thread. 1000 // These are invoked in channel's background thread.
999 // Cannot call any method of the activex here since it is a STA kind of being. 1001 // Cannot call any method of the activex here since it is a STA kind of being.
1000 // By default we marshal the IPC message to the main/GUI thread and from there 1002 // By default we marshal the IPC message to the main/GUI thread and from there
1001 // we safely invoke chrome_frame_delegate_->OnMessageReceived(msg). 1003 // we safely invoke chrome_frame_delegate_->OnMessageReceived(msg).
1002 bool ChromeFrameAutomationClient::OnMessageReceived(TabProxy* tab, 1004 bool ChromeFrameAutomationClient::OnMessageReceived(TabProxy* tab,
1003 const IPC::Message& msg) { 1005 const IPC::Message& msg) {
1004 DCHECK(tab == tab_.get()); 1006 DCHECK(tab == tab_.get());
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
1265 const net::URLRequestStatus& status) { 1267 const net::URLRequestStatus& status) {
1266 automation_server_->Send(new AutomationMsg_RequestEnd( 1268 automation_server_->Send(new AutomationMsg_RequestEnd(
1267 tab_->handle(), request_id, status)); 1269 tab_->handle(), request_id, status));
1268 } 1270 }
1269 1271
1270 void ChromeFrameAutomationClient::OnCookiesRetrieved(bool success, 1272 void ChromeFrameAutomationClient::OnCookiesRetrieved(bool success,
1271 const GURL& url, const std::string& cookie_string, int cookie_id) { 1273 const GURL& url, const std::string& cookie_string, int cookie_id) {
1272 automation_server_->Send(new AutomationMsg_GetCookiesHostResponse( 1274 automation_server_->Send(new AutomationMsg_GetCookiesHostResponse(
1273 tab_->handle(), success, url, cookie_string, cookie_id)); 1275 tab_->handle(), success, url, cookie_string, cookie_id));
1274 } 1276 }
OLDNEW
« no previous file with comments | « chrome_frame/cfproxy_test.cc ('k') | chrome_frame/crash_reporting/nt_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698