Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9109012: Fix static type warnings in test.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_progress.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 4828cbb4afcc49557d12c48416ac5170e2aefcfc..52b329a54da586035983807899049322304aa24e 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -193,7 +193,7 @@ class RunningProcess {
}
}
- void makeReadHandler(StringInputStream source, List<String> destination) {
+ Function makeReadHandler(StringInputStream source, List<String> destination) {
return () {
if (source.closed) return; // TODO(whesse): Remove when bug is fixed.
var line = source.readLine();
@@ -249,8 +249,8 @@ class DartcBatchRunnerProcess {
StringInputStream _stderrStream;
TestCase _currentTest;
- StringBuffer _testStdout;
- StringBuffer _testStderr;
+ List<String> _testStdout;
+ List<String> _testStderr;
Date _startTime;
Timer _timer;
@@ -319,7 +319,7 @@ class DartcBatchRunnerProcess {
test.completed();
}
- void _readOutput(StringInputStream stream, List<String> buffer) {
+ Function _readOutput(StringInputStream stream, List<String> buffer) {
return () {
var status;
var line = stream.readLine();
@@ -354,7 +354,7 @@ class DartcBatchRunnerProcess {
});
}
- void _timeoutHandler(TestCase test) {
+ Function _timeoutHandler(TestCase test) {
return (ignore) {
_process.exitHandler = (exitCode) {
_process.close();
« no previous file with comments | « tools/testing/dart/test_progress.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698