Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 9109012: Fix static type warnings in test.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index ffe10721f219df000895157b3416039abd1fc124..359b2a1eeba6c3b8b9679c2005ba056ae11e6a7b 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -32,7 +32,7 @@ class ProgressIndicator {
}
}
- void testAdded() => _foundTests++;
+ void testAdded() { _foundTests++; }
void start(TestCase test) {
_printStartProgress(test);
@@ -79,8 +79,8 @@ class ProgressIndicator {
exit(_failedTests > 0 ? 1 : 0);
}
- abstract _printStartProgress();
- abstract _printDoneProgress();
+ abstract _printStartProgress(TestCase test);
+ abstract _printDoneProgress(TestCase test);
String _pad(String s, int length) {
StringBuffer buffer = new StringBuffer();
@@ -169,6 +169,8 @@ class CompactIndicator extends ProgressIndicator {
void _printStartProgress(TestCase test) => _printProgress();
void _printDoneProgress(TestCase test) => _printProgress();
+
+ abstract void _printProgress();
}
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698