Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 9107014: Makes window focused for gpu pixel test (Closed)

Created:
8 years, 11 months ago by pkotwicz
Modified:
8 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, apatrick_chromium, Zhenyao Mo
Visibility:
Public.

Description

Makes window focused for pixel test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117356

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changes as requested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
8 years, 11 months ago (2012-01-11 20:20:30 UTC) #1
sky
http://codereview.chromium.org/9107014/diff/1/chrome/test/gpu/gpu_pixel_browsertest.cc File chrome/test/gpu/gpu_pixel_browsertest.cc (right): http://codereview.chromium.org/9107014/diff/1/chrome/test/gpu/gpu_pixel_browsertest.cc#newcode315 chrome/test/gpu/gpu_pixel_browsertest.cc:315: browser()->window()->Activate(); Use ui_test_utils::SHowAndFocusNativeWindow and ASSERT on the result.
8 years, 11 months ago (2012-01-11 22:29:25 UTC) #2
pkotwicz
8 years, 11 months ago (2012-01-11 23:35:48 UTC) #3
sky
LGTM
8 years, 11 months ago (2012-01-11 23:38:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/9107014/2002
8 years, 11 months ago (2012-01-12 00:19:52 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-12 01:53:27 UTC) #6
Change committed as 117356

Powered by Google App Engine
This is Rietveld 408576698