[uber page] Convert 'Under the Hood' page to a sub-page.

[uber page] Convert 'Under the Hood' page to a sub-page.

BUG=107604
TEST=Verify that 'Open Under the hood' button works correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116437

[csilv, 2012-01-04 23:28:52]

+jhawkins for review

[James Hawkins, 2012-01-04 23:34:30]

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/browser_options.html (right):

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/browser_options.html:128: <button
id="advancedOptionsButton"
IDs use dash-form. Damnit; I now see that this file is not legit for
style...ignore for now.

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options.html (left):

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/options.html:132: <include
src="about_page.html">
Where do these go now?

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options_page.css (right):

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/options_page.css:274:
#subpage-sheet-container-3 {
Blah..this should be temporary, right?

[csilv, 2012-01-04 23:48:22]

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options.html (left):

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/options.html:132: <include
src="about_page.html">
On 2012/01/04 23:34:30, James Hawkins wrote:
> Where do these go now?

These pages are not accessible in options2, so I'll revert the change for
simplicity.  'About' is a top-level page so it has to come out of settings and
be moved into a new page.  (I'll file a bug).

I don't know about the picture since it's not included Glen's specs.  I'll ask
for clarification.

[James Hawkins, 2012-01-04 23:54:35]

LGTM

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options2/options.html (left):

http://codereview.chromium.org/9091015/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options2/options.html:132: <include
src="about_page.html">
On 2012/01/04 23:48:23, csilv wrote:
> On 2012/01/04 23:34:30, James Hawkins wrote:
> > Where do these go now?
> 
> These pages are not accessible in options2, so I'll revert the change for
> simplicity.  'About' is a top-level page so it has to come out of settings and
> be moved into a new page.  (I'll file a bug).
> 
> I don't know about the picture since it's not included Glen's specs.  I'll ask
> for clarification.

Thanks!

[commit-bot: I haz the power, 2012-01-04 23:58:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csilv@chromium.org/9091015/5001

[commit-bot: I haz the power, 2012-01-05 00:48:36]

Try job failure for 9091015-5001 (previous was lost) (retry) on linux_clang for
step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-01-05 00:53:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csilv@chromium.org/9091015/5001

[commit-bot: I haz the power, 2012-01-05 02:10:03]

Change committed as 116437