Output generated headers using Python's "wb" mode, to prevent EOL-munging.

Output generated headers using Python's "wb" mode, to prevent EOL-munging.

This results in PPAPI headers always being generated with Unix line-endings.

BUG=109116
TEST=Re-generate PPAPI headers on a Windows system, using a Windows-native version of Python, and verify that the generated headers have Unix line-endings.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118245

[Wez, 2012-01-04 12:36:19]

Hopefully this will result in brettw@ checking in files with CRLF end-of-line
less often. ;)

[Wez, 2012-01-10 20:58:57]

Pingy. ;)

[noelallen1, 2012-01-18 22:59:04]

Add 'b' on read then LGTM, otherwise, if you think that's the wrong way to go we
should probably hash it out.

http://codereview.chromium.org/9088010/diff/1/ppapi/generators/idl_outfile.py
File ppapi/generators/idl_outfile.py (right):

http://codereview.chromium.org/9088010/diff/1/ppapi/generators/idl_outfile.py...
ppapi/generators/idl_outfile.py:84: intext = open(filename, 'r').read()
Seems that if you write 'b' you should read 'b'.  Otherwise you will miss the
change in line endings when you compare.  While it may seem a good idea to
ignore files that "currently" have the incorrect line ending, it would miss
cases where the ending was accidentally changed.

[commit-bot: I haz the power, 2012-01-19 01:40:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/9088010/5001

[commit-bot: I haz the power, 2012-01-19 05:24:54]

Change committed as 118245