Output generated headers using Python's "wb" mode, to prevent EOL-munging.

ppapi/generators/idl_outfile.py

 #!/usr/bin/python
 #
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Output file objects for generator. """
 
 import difflib
 import os
@@ skipping 63 matching lines @@
       raise RuntimeError('Could not write to closed file %s.' % self.filename)
     self.outlist.append(string)
 
   # Close the file
   def Close(self):
     filename = os.path.realpath(self.filename)
     self.open = False
     outtext = ''.join(self.outlist)
     if not self.always_write:
       if os.path.isfile(filename):
         intext = open(filename, 'r').read()

[noelallen1, 2012/01/18 22:59:04]

Seems that if you write 'b' you should read 'b'.  Otherwise you will miss the
change in line endings when you compare.  While it may seem a good idea to
ignore files that "currently" have the incorrect line ending, it would miss
cases where the ending was accidentally changed.

       else:
         intext = ''
 
       if IsEquivelent(intext, outtext):
         if GetOption('verbose'):
           InfoOut.Log('Output %s unchanged.' % self.filename)
         return False
 
     if GetOption('diff'):
       for line in difflib.unified_diff(intext.split('\n'), outtext.split('\n'),
                                        'OLD ' + self.filename,
                                        'NEW ' + self.filename,
                                        n=1, lineterm=''):
         ErrOut.Log(line)
 
     try:
       # If the directory does not exit, try to create it, if we fail, we
       # still get the exception when the file is openned.
       basepath, leafname = os.path.split(filename)
       if basepath and not os.path.isdir(basepath) and self.create_dir:
         InfoOut.Log('Creating directory: %s\n' % basepath)
         os.makedirs(basepath)
 
       if not GetOption('test'):
-        outfile = open(filename, 'w')
+        outfile = open(filename, 'wb')
         outfile.write(outtext)
         InfoOut.Log('Output %s written.' % self.filename)
       return True
 
     except IOError as (errno, strerror):
       ErrOut.Log("I/O error(%d): %s" % (errno, strerror))
     except:
       ErrOut.Log("Unexpected error: %s" % sys.exc_info()[0])
       raise
 
@@ skipping 46 matching lines @@
   # Test conditionally writing the file skipping
   errors += TestFile(filename, stringlist, force=False, update=False)
 
   # Test conditionally writing the file updating
   errors += TestFile(filename, stringlist + ['X'], force=False, update=True)
 
   # Clean up file
   os.remove(filename)
   if not errors: InfoOut.Log('All tests pass.')
   sys.exit(errors)
-