base::Bind: Remove Task.

base::Bind: Remove Task.

BUG=none
TEST=none
R=awong

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116439

[awong, 2012-01-04 02:17:28]

LGTM !!!~~!!!~~~~~  with 1 nit.

http://codereview.chromium.org/9086002/diff/1/base/files/file_path_watcher_li...
File base/files/file_path_watcher_linux.cc (right):

http://codereview.chromium.org/9086002/diff/1/base/files/file_path_watcher_li...
base/files/file_path_watcher_linux.cc:155: void InotifyReaderCallback(
Move the parameters up to the ( and align there?

http://www.chromium.org/developers/coding-style

http://codereview.chromium.org/9086002/diff/1/base/message_loop.h
File base/message_loop.h (left):

http://codereview.chromium.org/9086002/diff/1/base/message_loop.h#oldcode194
base/message_loop.h:194: // Once the transition is done, the functions above
should be deleted.
oh this looks so nice...

[James Hawkins, 2012-01-04 02:24:17]

http://codereview.chromium.org/9086002/diff/1/base/files/file_path_watcher_li...
File base/files/file_path_watcher_linux.cc (right):

http://codereview.chromium.org/9086002/diff/1/base/files/file_path_watcher_li...
base/files/file_path_watcher_linux.cc:155: void InotifyReaderCallback(
On 2012/01/04 02:17:28, awong wrote:
> Move the parameters up to the ( and align there?
> 
> http://www.chromium.org/developers/coding-style

Give the same number of lines required, I prefer keeping all arguments on the
same line.

I'm not sure who added that part of the coding style guide, but I'm going to
bring up an objection on chromium-dev.  Thanks for the link though.

[awong, 2012-01-04 20:29:23]

On 2012/01/04 02:24:17, James Hawkins wrote:
>
http://codereview.chromium.org/9086002/diff/1/base/files/file_path_watcher_li...
> File base/files/file_path_watcher_linux.cc (right):
> 
>
http://codereview.chromium.org/9086002/diff/1/base/files/file_path_watcher_li...
> base/files/file_path_watcher_linux.cc:155: void InotifyReaderCallback(
> On 2012/01/04 02:17:28, awong wrote:
> > Move the parameters up to the ( and align there?
> > 
> > http://www.chromium.org/developers/coding-style
> 
> Give the same number of lines required, I prefer keeping all arguments on the
> same line.
> 
> I'm not sure who added that part of the coding style guide, but I'm going to
> bring up an objection on chromium-dev.  Thanks for the link though.

<putting on readability reviewer hat...>

Since the guide calls out this form of wrapping explicitly as incorrect, I think
we should match the stated rules until the guide gets amended.  The consistency
rule is generally considered a trump...

[James Hawkins, 2012-01-04 23:22:39]

On 2012/01/04 20:29:23, awong wrote:
> On 2012/01/04 02:24:17, James Hawkins wrote:
> >
>
http://codereview.chromium.org/9086002/diff/1/base/files/file_path_watcher_li...
> > File base/files/file_path_watcher_linux.cc (right):
> > 
> >
>
http://codereview.chromium.org/9086002/diff/1/base/files/file_path_watcher_li...
> > base/files/file_path_watcher_linux.cc:155: void InotifyReaderCallback(
> > On 2012/01/04 02:17:28, awong wrote:
> > > Move the parameters up to the ( and align there?
> > > 
> > > http://www.chromium.org/developers/coding-style
> > 
> > Give the same number of lines required, I prefer keeping all arguments on
the
> > same line.
> > 
> > I'm not sure who added that part of the coding style guide, but I'm going to
> > bring up an objection on chromium-dev.  Thanks for the link though.
> 
> <putting on readability reviewer hat...>
> 
> Since the guide calls out this form of wrapping explicitly as incorrect, I
think
> we should match the stated rules until the guide gets amended.  The
consistency
> rule is generally considered a trump...

Done. Going off try jobs from PS1.