Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: base/message_loop_proxy.h

Issue 9086002: base::Bind: Remove Task. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style fix. Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop.cc ('k') | base/message_loop_proxy_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop_proxy.h
diff --git a/base/message_loop_proxy.h b/base/message_loop_proxy.h
index b6da5e4a35a73675dae02ad401faf766ff9eb52e..6220eb76793ba62b43fe1c83895c04f363e01a3b 100644
--- a/base/message_loop_proxy.h
+++ b/base/message_loop_proxy.h
@@ -33,33 +33,14 @@ class BASE_EXPORT MessageLoopProxy
MessageLoopProxyTraits> {
public:
// These methods are the same as in message_loop.h, but are guaranteed to
- // either post the Task to the MessageLoop (if it's still alive), or to
- // delete the Task otherwise.
+ // either post the Task to the MessageLoop (if it's still alive), or the task
+ // is discarded.
// They return true iff the thread existed and the task was posted. Note that
// even if the task is posted, there's no guarantee that it will run; for
// example the target loop may already be quitting, or in the case of a
// delayed task a Quit message may preempt it in the message loop queue.
// Conversely, a return value of false is a guarantee the task will not run.
virtual bool PostTask(const tracked_objects::Location& from_here,
- Task* task) = 0;
- virtual bool PostDelayedTask(const tracked_objects::Location& from_here,
- Task* task,
- int64 delay_ms) = 0;
- virtual bool PostNonNestableTask(const tracked_objects::Location& from_here,
- Task* task) = 0;
- virtual bool PostNonNestableDelayedTask(
- const tracked_objects::Location& from_here,
- Task* task,
- int64 delay_ms) = 0;
-
- // TODO(ajwong): Remove the functions above once the Task -> Closure migration
- // is complete.
- //
- // There are 2 sets of Post*Task functions, one which takes the older Task*
- // function object representation, and one that takes the newer base::Closure.
- // We have this overload to allow a staged transition between the two systems.
- // Once the transition is done, the functions above should be deleted.
- virtual bool PostTask(const tracked_objects::Location& from_here,
const base::Closure& task) = 0;
virtual bool PostDelayedTask(const tracked_objects::Location& from_here,
const base::Closure& task,
« no previous file with comments | « base/message_loop.cc ('k') | base/message_loop_proxy_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698