Issue 9078005: Remove almost all remaining TOUCH_UIs.

Issue 9078005: Remove almost all remaining TOUCH_UIs. (Closed)

Created:
8 years, 11 months ago by bryeung

Modified:
8 years, 11 months ago

Reviewers:
Nikita (slow), sky, Dmitry Polukhin, Erik does not do reviews, jam, Yusuke Sato, Aaron Boodman, Peng

CC:
chromium-reviews, jstritar+watch_chromium.org, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, penghuang+watch_chromium.org, Aaron Boodman, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove almost all remaining TOUCH_UIs. TEST=ran tests BUG=105046 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117291

Patch Set 1 #

Patch Set 2 : add one more file #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : rebase #

Patch Set 5 : another clean rebase #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -47 lines)			Patch
M	chrome/browser/chromeos/login/login_utils.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_input_api.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_input_ui_apitest.cc	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/logging_chrome_uitest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/input_ui/chromeos_touch/manifest.json	View	1 2	1 chunk	+0 lines, -10 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/input_ui/chromeos_touch/test.html	View		1 chunk	+0 lines, -6 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/input_ui/chromeos_touch/test.js	View		1 chunk	+0 lines, -16 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/input_ui/chromeos_virtual_keyboard/manifest.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/input_ui/chromeos_virtual_keyboard/test.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/input_ui/chromeos_virtual_keyboard/test.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/base/ime/input_method_base.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1 2 3	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/9078005/diff/8002/chrome/browser/extensions/extension_input_ui_apitest.cc File chrome/browser/extensions/extension_input_ui_apitest.cc (right): http://codereview.chromium.org/9078005/diff/8002/chrome/browser/extensions/extension_input_ui_apitest.cc#newcode13 chrome/browser/extensions/extension_input_ui_apitest.cc:13: message_; nit: this should be indented 4 spaces.

8 years, 11 months ago (2012-01-04 17:27:05 UTC) #2

bryeung

Thanks Scott & John for the early review! Nikita: can you look at the login ...

8 years, 11 months ago (2012-01-04 18:29:57 UTC) #3

Peng

IME changes lgtm On 2012/01/04 18:29:57, bryeung wrote: > Thanks Scott & John for the ...

8 years, 11 months ago (2012-01-04 18:33:35 UTC) #4

Yusuke Sato

IME part LGTM On 2012/01/04 18:33:35, Peng wrote: > IME changes lgtm > > On ...

8 years, 11 months ago (2012-01-05 02:26:02 UTC) #5

bryeung

Nikita/Dimitry: can you please look at the login changes? Aaron/Erik: can you please look at ...

8 years, 11 months ago (2012-01-06 18:04:57 UTC) #6