Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/common/logging_chrome_uitest.cc

Issue 9078005: Remove almost all remaining TOUCH_UIs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: another clean rebase Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #endif 9 #endif
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 #if defined(OS_LINUX) && (!defined(NDEBUG) || !defined(USE_LINUX_BREAKPAD)) 69 #if defined(OS_LINUX) && (!defined(NDEBUG) || !defined(USE_LINUX_BREAKPAD))
70 // On Linux in Debug mode, Chrome generates a SIGTRAP. 70 // On Linux in Debug mode, Chrome generates a SIGTRAP.
71 // we do not catch SIGTRAPs, thus no crash dump. 71 // we do not catch SIGTRAPs, thus no crash dump.
72 // This also does not work if Breakpad is disabled. 72 // This also does not work if Breakpad is disabled.
73 #define EXPECTED_ASSERT_CRASHES 0 73 #define EXPECTED_ASSERT_CRASHES 0
74 #else 74 #else
75 #define EXPECTED_ASSERT_CRASHES 1 75 #define EXPECTED_ASSERT_CRASHES 1
76 #endif 76 #endif
77 77
78 // Touch build will start an extra renderer process (the extension process) 78 // Virtual keyboard build will start an extra renderer process (the extension
79 // for the virtual keyboard. 79 // process) for the virtual keyboard.
80 #if defined(TOUCH_UI) 80 #if defined(USE_VIRTUAL_KEYBOARD)
81 #define EXPECTED_ASSERT_ERRORS 2 81 #define EXPECTED_ASSERT_ERRORS 2
82 #else 82 #else
83 #define EXPECTED_ASSERT_ERRORS 1 83 #define EXPECTED_ASSERT_ERRORS 1
84 #endif 84 #endif
85 85
86 #if !defined(NDEBUG) // We don't have assertions in release builds. 86 #if !defined(NDEBUG) // We don't have assertions in release builds.
87 // Tests whether we correctly fail on renderer assertions during tests. 87 // Tests whether we correctly fail on renderer assertions during tests.
88 class AssertionTest : public UITest { 88 class AssertionTest : public UITest {
89 protected: 89 protected:
90 AssertionTest() { 90 AssertionTest() {
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 #else 164 #else
165 #define MAYBE_Crash Crash 165 #define MAYBE_Crash Crash
166 #endif 166 #endif
167 // Launch the app in renderer crash test mode, then close the app. 167 // Launch the app in renderer crash test mode, then close the app.
168 TEST_F(RendererCrashTest, MAYBE_Crash) { 168 TEST_F(RendererCrashTest, MAYBE_Crash) {
169 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0)); 169 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
170 ASSERT_TRUE(browser.get()); 170 ASSERT_TRUE(browser.get());
171 ASSERT_TRUE(browser->WaitForTabCountToBecome(1)); 171 ASSERT_TRUE(browser->WaitForTabCountToBecome(1));
172 expected_crashes_ = EXPECTED_CRASH_CRASHES; 172 expected_crashes_ = EXPECTED_CRASH_CRASHES;
173 } 173 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698