Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9076002: Initial views touchui Gesture Recognizer support (Closed)

Created:
8 years, 11 months ago by Ian Vollick
Modified:
8 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Initial views touchui Gesture Recognizer support This is just a merge of Gajen's patch (http://codereview.chromium.org/8364039/) with ToT. BUG=101645 TEST=views_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117869 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117894

Patch Set 1 #

Patch Set 2 : Fix views_unittests compilation error. #

Patch Set 3 : Attempt to correct bogus velocities. #

Patch Set 4 : . #

Patch Set 5 : Fix win release build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1005 lines, -3 lines) Patch
M ui/base/events.h View 2 chunks +18 lines, -0 lines 0 comments Download
M ui/views/events/event.h View 2 chunks +37 lines, -0 lines 0 comments Download
M ui/views/events/event.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A ui/views/touchui/gesture_recognizer.h View 1 chunk +177 lines, -0 lines 0 comments Download
A ui/views/touchui/gesture_recognizer.cc View 3 1 chunk +287 lines, -0 lines 0 comments Download
M ui/views/view.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M ui/views/view_unittest.cc View 1 2 3 4 7 chunks +334 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/widget/root_view.h View 1 2 3 5 chunks +15 lines, -0 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 2 3 7 chunks +73 lines, -2 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
Rubber stamp LGTM since this is just a copy of an existing patch that was ...
8 years, 11 months ago (2012-01-05 19:18:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/9076002/15001
8 years, 11 months ago (2012-01-17 01:35:05 UTC) #2
commit-bot: I haz the power
Try job failure for 9076002-15001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 11 months ago (2012-01-17 01:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/9076002/15005
8 years, 11 months ago (2012-01-17 02:24:23 UTC) #4
commit-bot: I haz the power
8 years, 11 months ago (2012-01-17 03:28:29 UTC) #5 
Change committed as 117869

Powered by Google App Engine
This is Rietveld 408576698