Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: chrome/browser/sync/engine/resolve_conflicts_command.cc

Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/resolve_conflicts_command.cc
diff --git a/chrome/browser/sync/engine/resolve_conflicts_command.cc b/chrome/browser/sync/engine/resolve_conflicts_command.cc
index e76b1c7f19259312697b15e331074dbf5521076f..253312e566608ff73b449d863d310b3069a6d429 100644
--- a/chrome/browser/sync/engine/resolve_conflicts_command.cc
+++ b/chrome/browser/sync/engine/resolve_conflicts_command.cc
@@ -19,26 +19,26 @@ std::set<ModelSafeGroup> ResolveConflictsCommand::GetGroupsToChange(
return session.GetEnabledGroupsWithConflicts();
}
-void ResolveConflictsCommand::ModelChangingExecuteImpl(
+SyncerError ResolveConflictsCommand::ModelChangingExecuteImpl(
sessions::SyncSession* session) {
ConflictResolver* resolver = session->context()->resolver();
- DCHECK(resolver);
- if (!resolver)
- return;
+ CHECK(resolver);
syncable::ScopedDirLookup dir(session->context()->directory_manager(),
session->context()->account_name());
if (!dir.good())
- return;
+ return DIRECTORY_LOOKUP_FAILED;
sessions::StatusController* status = session->mutable_status_controller();
const sessions::ConflictProgress* progress = status->conflict_progress();
if (!progress)
- return; // Nothing to do.
+ return NO_ERROR; // Nothing to do.
syncable::WriteTransaction trans(FROM_HERE, syncable::SYNCER, dir);
const Cryptographer* cryptographer =
session->context()->directory_manager()->GetCryptographer(&trans);
status->update_conflicts_resolved(
resolver->ResolveConflicts(&trans, cryptographer, *progress, status));
+
+ return NO_ERROR;
}
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/engine/resolve_conflicts_command.h ('k') | chrome/browser/sync/engine/store_timestamps_command.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698