Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/sync/engine/resolve_conflicts_command.cc

Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/engine/resolve_conflicts_command.h" 5 #include "chrome/browser/sync/engine/resolve_conflicts_command.h"
6 6
7 #include "chrome/browser/sync/engine/conflict_resolver.h" 7 #include "chrome/browser/sync/engine/conflict_resolver.h"
8 #include "chrome/browser/sync/sessions/session_state.h" 8 #include "chrome/browser/sync/sessions/session_state.h"
9 #include "chrome/browser/sync/sessions/sync_session.h" 9 #include "chrome/browser/sync/sessions/sync_session.h"
10 #include "chrome/browser/sync/syncable/directory_manager.h" 10 #include "chrome/browser/sync/syncable/directory_manager.h"
11 11
12 namespace browser_sync { 12 namespace browser_sync {
13 13
14 ResolveConflictsCommand::ResolveConflictsCommand() {} 14 ResolveConflictsCommand::ResolveConflictsCommand() {}
15 ResolveConflictsCommand::~ResolveConflictsCommand() {} 15 ResolveConflictsCommand::~ResolveConflictsCommand() {}
16 16
17 std::set<ModelSafeGroup> ResolveConflictsCommand::GetGroupsToChange( 17 std::set<ModelSafeGroup> ResolveConflictsCommand::GetGroupsToChange(
18 const sessions::SyncSession& session) const { 18 const sessions::SyncSession& session) const {
19 return session.GetEnabledGroupsWithConflicts(); 19 return session.GetEnabledGroupsWithConflicts();
20 } 20 }
21 21
22 void ResolveConflictsCommand::ModelChangingExecuteImpl( 22 SyncerError ResolveConflictsCommand::ModelChangingExecuteImpl(
23 sessions::SyncSession* session) { 23 sessions::SyncSession* session) {
24 ConflictResolver* resolver = session->context()->resolver(); 24 ConflictResolver* resolver = session->context()->resolver();
25 DCHECK(resolver); 25 CHECK(resolver);
26 if (!resolver)
27 return;
28 26
29 syncable::ScopedDirLookup dir(session->context()->directory_manager(), 27 syncable::ScopedDirLookup dir(session->context()->directory_manager(),
30 session->context()->account_name()); 28 session->context()->account_name());
31 if (!dir.good()) 29 if (!dir.good())
32 return; 30 return DIRECTORY_LOOKUP_FAILED;
33 sessions::StatusController* status = session->mutable_status_controller(); 31 sessions::StatusController* status = session->mutable_status_controller();
34 const sessions::ConflictProgress* progress = status->conflict_progress(); 32 const sessions::ConflictProgress* progress = status->conflict_progress();
35 if (!progress) 33 if (!progress)
36 return; // Nothing to do. 34 return NO_ERROR; // Nothing to do.
37 syncable::WriteTransaction trans(FROM_HERE, syncable::SYNCER, dir); 35 syncable::WriteTransaction trans(FROM_HERE, syncable::SYNCER, dir);
38 const Cryptographer* cryptographer = 36 const Cryptographer* cryptographer =
39 session->context()->directory_manager()->GetCryptographer(&trans); 37 session->context()->directory_manager()->GetCryptographer(&trans);
40 status->update_conflicts_resolved( 38 status->update_conflicts_resolved(
41 resolver->ResolveConflicts(&trans, cryptographer, *progress, status)); 39 resolver->ResolveConflicts(&trans, cryptographer, *progress, status));
40
41 return NO_ERROR;
42 } 42 }
43 43
44 } // namespace browser_sync 44 } // namespace browser_sync
OLDNEW
« no previous file with comments | « chrome/browser/sync/engine/resolve_conflicts_command.h ('k') | chrome/browser/sync/engine/store_timestamps_command.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698