Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 9034032: And now NewRunnableMethod(), you die. (Closed)

Created:
8 years, 11 months ago by awong
Modified:
8 years, 11 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, vrk (LEFT CHROMIUM), jam, sadrul, nkostylev+watch_chromium.org, kkania, amit, annacc+watch_chromium.org, dcheng, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, cbentzel+watch_chromium.org, acolwell+watch_chromium.org, prasadt, joi+watch-content_chromium.org, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, ihf+watch_chromium.org, michaeln, jennb, ddorwin+watch_chromium.org, fischman+watch_chromium.org, sanjeevr, jianli, dpranke-watch+content_chromium.org, simonmorris+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Dmitry Titov, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org, csilv, groby-ooo-7-16, Tyler Breisacher (Chromium), akalin, willchan no longer on Chromium
Visibility:
Public.

Description

And now NewRunnableMethod(), you die. Kill off NewRunnableMethod() and remove silly declarations of unused ScopedRunnableMethodFactory(s). BUG=none TEST=existing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116250

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : fix chrome_frame_automation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -401 lines) Patch
M base/callback.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/callback.h.pump View 1 chunk +0 lines, -4 lines 0 comments Download
M base/message_loop_unittest.cc View 1 2 chunks +0 lines, -38 lines 0 comments Download
M base/message_pump_glib_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M base/task.h View 1 1 chunk +3 lines, -225 lines 0 comments Download
M base/task_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/browsing_data_remover.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/audio_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/customization_document.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/mobile_config.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/service/service_process_control.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/service/service_process_control_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/service/service_process.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/webdriver/webdriver_automation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/webdriver/webdriver_session.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/audio/audio_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/capture/fake_video_capture_device.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/capture/linux/video_capture_device_linux.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/capture/video_capture_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/plugin/host_script_object.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
awong
building off of http://codereview.chromium.org/8960011/ getting closer!!!
8 years, 11 months ago (2011-12-30 00:22:34 UTC) #1
James Hawkins
8 years, 11 months ago (2012-01-01 00:25:11 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698