Codemirror dart port StringStream datatype babysteps.

Codemirror dart port StringStream datatype babysteps.

This is intended to be a pretty faithful port of codemirror (2.18).

That source can be fetched here: http://codemirror.net/codemirror-2.18.zip

I've attempted to emulate some of the idioms I've picked up from
Bob's article and bits of the frog and core lib sources but I'm sure
there will be some bits that cry foul to a seasoned darter.  In other
words, improvements, pointers, finger wags all greatly appreciated!
Committed: https://code.google.com/p/dart/source/detail?r=2934

[mattsh, 2011-12-30 13:48:15]

LGTM.  couple very tiny nits below

http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
File tools/codemirror/dart/lib/codemirror.dart (right):

http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
tools/codemirror/dart/lib/codemirror.dart:3: // BSD-style license that can be
found in the LICENSE file.
maybe include a reference back to the original codemirror source, and a TODO
here to figure out what to put here

http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
tools/codemirror/dart/lib/codemirror.dart:67: bool match(String pattern, [bool
consume =false,
space before false

http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
tools/codemirror/dart/lib/codemirror.dart:72: if
(cased(_string).indexOf(cased(pattern), _pos) != _pos) return false;
my personal preference is braces around all 'if' branches, just for clarity, so
I'd have the { return false; } in braces, but your choice.

http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
tools/codemirror/dart/lib/codemirror.dart:84: var tabSize = 8;
int instead of var

[pquitslund, 2012-01-02 04:18:29]

On 2011/12/30 13:48:15, mattsh wrote:
> LGTM.  couple very tiny nits below
> 
>
http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
> File tools/codemirror/dart/lib/codemirror.dart (right):
> 
>
http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
> tools/codemirror/dart/lib/codemirror.dart:3: // BSD-style license that can be
> found in the LICENSE file.
> maybe include a reference back to the original codemirror source, and a TODO
> here to figure out what to put here

Good catch.  Done.  Let me know if you'd like to see other text...

>
http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
> tools/codemirror/dart/lib/codemirror.dart:67: bool match(String pattern, [bool
> consume =false,
> space before false

Fixed!

>
http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
> tools/codemirror/dart/lib/codemirror.dart:72: if
> (cased(_string).indexOf(cased(pattern), _pos) != _pos) return false;
> my personal preference is braces around all 'if' branches, just for clarity,
so
> I'd have the { return false; } in braces, but your choice.

I need to get an opinion on braces (I'm so steeped in Java that this all seems
pretty weird).  For now I'll leave it as is but expect a revamp once I know
where I stand.  Thanks for the 2 cents in the meantime!

> 
>
http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
> tools/codemirror/dart/lib/codemirror.dart:84: var tabSize = 8;
> int instead of var

Right!  Fixed.

[Bob Nystrom, 2012-01-04 00:22:40]

http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
File tools/codemirror/dart/lib/codemirror.dart (right):

http://codereview.chromium.org/9034030/diff/1/tools/codemirror/dart/lib/codem...
tools/codemirror/dart/lib/codemirror.dart:72: if
(cased(_string).indexOf(cased(pattern), _pos) != _pos) return false;
On 2011/12/30 13:48:16, mattsh wrote:
> my personal preference is braces around all 'if' branches, just for clarity,
so
> I'd have the { return false; } in braces, but your choice.

I believe we generally don't do braces for single-line ifs.