Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9030032: Get rid of a bunch of tab_contents.h includes from chrome. These are all trivial changes to use W... (Closed)

Created:
8 years, 11 months ago by jam
Modified:
8 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, vrk (LEFT CHROMIUM), nkostylev+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, GeorgeY, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, Ilya Sherman, acolwell+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, annacc+watch_chromium.org, zork+watch_chromium.org, ihf+watch_chromium.org, jstritar+watch_chromium.org, dtseng+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, rdsmith+dwatch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, yuzo+watch_chromium.org, dpranke-watch+content_chromium.org, ctguil+watch_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, kkania, hashimoto+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, robertshield, mmenke, dyu1, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Get rid of a bunch of tab_contents.h includes from chrome. These are all trivial changes to use WebContents instead of TabContents. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116392

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : fix cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -325 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_application_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/external_protocol_dialog.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/external_protocol_dialog.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/html_page_screen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock_window_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/web_page_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/browser_list_tabcontents_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_file_picker.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/download/download_file_picker.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_request_limiter.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/download/download_util.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_debugger_api.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_debugger_api.cc View 13 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_page_capture_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_processes_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_protocol/external_protocol_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_protocol/external_protocol_observer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/instant/instant_controller.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 7 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_tab_observer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sessions/restore_tab_helper.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/sessions/restore_tab_helper.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/speech/speech_input_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/confirm_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/insecure_content_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_ssl_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_source_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_notification_resource_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 11 chunks +17 lines, -22 lines 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/sad_tab_observer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/debugger/devtools_frontend_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_frontend_host.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/debugger/devtools_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/mock_download_manager_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/save_package.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/devtools_client_host.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/public/browser/devtools_frontend_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/devtools_http_handler_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/browser/devtools_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/download_manager_delegate.h View 4 chunks +5 lines, -6 lines 0 comments Download
M content/public/browser/notification_types.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/shell_download_manager_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 11 months ago (2012-01-04 21:46:46 UTC) #1
Elliot Glaysher
8 years, 11 months ago (2012-01-04 21:59:28 UTC) #2 
read the first half. Got bored. LGTM rubber stamp.

Powered by Google App Engine
This is Rietveld 408576698