chrome/browser/ui/sad_tab_observer.cc - Issue 9030032: Get rid of a bunch of tab_contents.h includes from chrome. These are all trivial changes to use W...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sad_tab_observer.cc

Issue 9030032: Get rid of a bunch of tab_contents.h includes from chrome. These are all trivial changes to use W... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix cros Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm ('k') | content/browser/debugger/devtools_frontend_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sad_tab_observer.cc

===================================================================

--- chrome/browser/ui/sad_tab_observer.cc (revision 116331)

+++ chrome/browser/ui/sad_tab_observer.cc (working copy)

@@ -19,10 +19,12 @@

#include "chrome/browser/ui/gtk/sad_tab_gtk.h"

#endif

+using content::WebContents;

SadTabObserver::SadTabObserver(TabContents* tab_contents)

: content::WebContentsObserver(tab_contents) {

- registrar_.Add(this, content::NOTIFICATION_TAB_CONTENTS_CONNECTED,

- content::Source<TabContents>(tab_contents));

+ registrar_.Add(this, content::NOTIFICATION_WEB_CONTENTS_CONNECTED,

+ content::Source<WebContents>(tab_contents));

}

SadTabObserver::~SadTabObserver() {

@@ -46,7 +48,7 @@

const content::NotificationSource& source,

const content::NotificationDetails& details) {

switch (type) {

- case content::NOTIFICATION_TAB_CONTENTS_CONNECTED:

+ case content::NOTIFICATION_WEB_CONTENTS_CONNECTED:

if (HasSadTab()) {

web_contents()->GetView()->RemoveOverlayView();

ReleaseSadTab();