Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 9024005: WebSocket Pepper API: aborting outstanding callbacks on destruction (Closed)

Created:
9 years ago by Takashi Toyoshima
Modified:
8 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

WebSocket Pepper API: aborting outstanding callbacks on destruction Outstanding callbacks must be aborted on object destruction. Never called callbacks which created via CompletionCallbackFactory cause object memory leaks. BUG=87310 TEST=ui_test --gtest_filter='PPAPITest.Websocket_*'

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M webkit/plugins/ppapi/ppb_websocket_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_websocket_impl.cc View 4 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Does this help with the memory leak at all? Looking around at other resources with ...
8 years, 12 months ago (2011-12-28 17:58:11 UTC) #1
Takashi Toyoshima
Thank you for advice. These classes must be the classes in shared_impl/callback_tracker and tracked_callback now, ...
8 years, 11 months ago (2012-01-10 09:25:26 UTC) #2
Takashi Toyoshima
Oh, I notice that brett already handled this issue. So, I just close this CL.
8 years, 11 months ago (2012-01-10 09:54:48 UTC) #3
Takashi Toyoshima
8 years, 11 months ago (2012-01-10 09:59:10 UTC) #4
FYI: brettw's CL is here http://codereview.chromium.org/9015013/

Powered by Google App Engine
This is Rietveld 408576698