Issue 9015013: Convert callers to use the new TrackedCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9015013: Convert callers to use the new TrackedCallback. (Closed)

Created:
8 years, 12 months ago by brettw

Modified:
8 years, 11 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Convert callers to use the new TrackedCallback. This converts callers in webkit/plugins/ppapi that used raw PP_CompletionCallbacks to use the new TrackedCallback code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116763

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -55 lines)			Patch
M	webkit/plugins/ppapi/audio_helper.h	View		3 chunks	+4 lines, -7 lines	0 comments	Download
M	webkit/plugins/ppapi/audio_helper.cc	View	1	4 chunks	+8 lines, -16 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_audio_impl.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_audio_input_impl.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_2d_impl.h	View	1	2 chunks	+10 lines, -6 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_2d_impl.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_websocket_impl.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_websocket_impl.cc	View		11 chunks	+19 lines, -19 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

What I said elsewhere about .get() checks.... Otherwise, everything except the websocket stuff (which isn't ...

8 years, 11 months ago (2012-01-03 22:55:20 UTC) #2

lgtm