Fix JavaScript accessors on objects with interceptors.

Fix JavaScript accessors on objects with interceptors.

This fixes how Object.defineProperty() defines JavaScript accessors on
objects with installed API interceptors. The definition itself does not
cause any interceptors to be called, whereas any subsequent accesses on
said object will still fire the interceptor. This behavior is in sync
with API accessors.

R=rossberg@chromium.org
BUG=v8:1651, chromium:94666
TEST=cctest/test-api

Committed: http://code.google.com/p/v8/source/detail?r=10293

[rossberg, 2011-12-21 15:58:41]

lgtm

http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:1443: THREADED_TEST(SwitchFromAccessorToInterceptor) {
Not your change, but could you add a variant of this test not using inheritance,
analogous to your new one below?

http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:1464: Handle<FunctionTemplate> child =
FunctionTemplate::New();
"child"? Where is the parent? ;)

[Michael Starzinger, 2011-12-21 16:15:01]

Added new patch set. Landed.

http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:1443: THREADED_TEST(SwitchFromAccessorToInterceptor) {
On 2011/12/21 15:58:42, rossberg wrote:
> Not your change, but could you add a variant of this test not using
inheritance,
> analogous to your new one below?

Done.

http://codereview.chromium.org/9021019/diff/1/test/cctest/test-api.cc#newcode...
test/cctest/test-api.cc:1464: Handle<FunctionTemplate> child =
FunctionTemplate::New();
On 2011/12/21 15:58:42, rossberg wrote:
> "child"? Where is the parent? ;)

Done. Renamed to "obj" instead.