Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/objects.cc

Issue 9021019: Fix JavaScript accessors on objects with interceptors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Andreas Rossberg. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4334 matching lines...) Expand 10 before | Expand all | Expand 10 after
4345 heap); 4345 heap);
4346 if (!probe->IsTheHole()) return probe; 4346 if (!probe->IsTheHole()) return probe;
4347 } 4347 }
4348 } 4348 }
4349 break; 4349 break;
4350 } 4350 }
4351 } 4351 }
4352 } else { 4352 } else {
4353 // Lookup the name. 4353 // Lookup the name.
4354 LookupResult result(heap->isolate()); 4354 LookupResult result(heap->isolate());
4355 LocalLookup(name, &result); 4355 LocalLookupRealNamedProperty(name, &result);
4356 if (result.IsProperty()) { 4356 if (result.IsProperty()) {
4357 // TODO(mstarzinger): We should check for result.IsDontDelete() here once 4357 // TODO(mstarzinger): We should check for result.IsDontDelete() here once
4358 // we only call into the runtime once to set both getter and setter. 4358 // we only call into the runtime once to set both getter and setter.
4359 if (result.type() == CALLBACKS) { 4359 if (result.type() == CALLBACKS) {
4360 Object* obj = result.GetCallbackObject(); 4360 Object* obj = result.GetCallbackObject();
4361 // Need to preserve old getters/setters. 4361 // Need to preserve old getters/setters.
4362 if (obj->IsFixedArray()) { 4362 if (obj->IsFixedArray()) {
4363 // Use set to update attributes. 4363 // Use set to update attributes.
4364 return SetPropertyCallback(name, obj, attributes); 4364 return SetPropertyCallback(name, obj, attributes);
4365 } 4365 }
(...skipping 8188 matching lines...) Expand 10 before | Expand all | Expand 10 after
12554 if (break_point_objects()->IsUndefined()) return 0; 12554 if (break_point_objects()->IsUndefined()) return 0;
12555 // Single break point. 12555 // Single break point.
12556 if (!break_point_objects()->IsFixedArray()) return 1; 12556 if (!break_point_objects()->IsFixedArray()) return 1;
12557 // Multiple break points. 12557 // Multiple break points.
12558 return FixedArray::cast(break_point_objects())->length(); 12558 return FixedArray::cast(break_point_objects())->length();
12559 } 12559 }
12560 #endif // ENABLE_DEBUGGER_SUPPORT 12560 #endif // ENABLE_DEBUGGER_SUPPORT
12561 12561
12562 12562
12563 } } // namespace v8::internal 12563 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698