chrome/renderer/static_v8_external_string_resource.h - Issue 9021001: Add an out-of-line destructor to this class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/static_v8_external_string_resource.h

Issue 9021001: Add an out-of-line destructor to this class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Explicitly make subclass destructor virtual. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/static_v8_external_string_resource.h

diff --git a/chrome/renderer/static_v8_external_string_resource.h b/chrome/renderer/static_v8_external_string_resource.h

index 27a8cd2d2e2dca1658a211235585cf2c7c98537a..e255a7d42f9e3841e5a0b757dac204f81b62f71e 100644

--- a/chrome/renderer/static_v8_external_string_resource.h

+++ b/chrome/renderer/static_v8_external_string_resource.h

@@ -17,6 +17,7 @@ class StaticV8ExternalAsciiStringResource

: public v8::String::ExternalAsciiStringResource {

public:

explicit StaticV8ExternalAsciiStringResource(const base::StringPiece& buffer);

+ virtual ~StaticV8ExternalAsciiStringResource();

virtual const char* data() const OVERRIDE;

virtual size_t length() const OVERRIDE;