Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: chrome/renderer/static_v8_external_string_resource.h

Issue 9021001: Add an out-of-line destructor to this class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Explicitly make subclass destructor virtual. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_EXTENSIONS_STATIC_V8_EXTERNAL_STRING_RESOURCE_H_ 5 #ifndef CHROME_RENDERER_EXTENSIONS_STATIC_V8_EXTERNAL_STRING_RESOURCE_H_
6 #define CHROME_RENDERER_EXTENSIONS_STATIC_V8_EXTERNAL_STRING_RESOURCE_H_ 6 #define CHROME_RENDERER_EXTENSIONS_STATIC_V8_EXTERNAL_STRING_RESOURCE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/string_piece.h" 10 #include "base/string_piece.h"
11 #include "v8/include/v8.h" 11 #include "v8/include/v8.h"
12 12
13 // A very simple implementation of v8::ExternalAsciiStringResource that just 13 // A very simple implementation of v8::ExternalAsciiStringResource that just
14 // wraps a buffer. The buffer must outlive the v8 runtime instance this resource 14 // wraps a buffer. The buffer must outlive the v8 runtime instance this resource
15 // is used in. 15 // is used in.
16 class StaticV8ExternalAsciiStringResource 16 class StaticV8ExternalAsciiStringResource
17 : public v8::String::ExternalAsciiStringResource { 17 : public v8::String::ExternalAsciiStringResource {
18 public: 18 public:
19 explicit StaticV8ExternalAsciiStringResource(const base::StringPiece& buffer); 19 explicit StaticV8ExternalAsciiStringResource(const base::StringPiece& buffer);
20 virtual ~StaticV8ExternalAsciiStringResource();
20 21
21 virtual const char* data() const OVERRIDE; 22 virtual const char* data() const OVERRIDE;
22 virtual size_t length() const OVERRIDE; 23 virtual size_t length() const OVERRIDE;
23 24
24 private: 25 private:
25 base::StringPiece buffer_; 26 base::StringPiece buffer_;
26 }; 27 };
27 28
28 #endif // CHROME_RENDERER_EXTENSIONS_STATIC_V8_EXTERNAL_STRING_RESOURCE_H_ 29 #endif // CHROME_RENDERER_EXTENSIONS_STATIC_V8_EXTERNAL_STRING_RESOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698