Issue 9021001: Add an out-of-line destructor to this class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9021001: Add an out-of-line destructor to this class. (Closed)

Created:
9 years ago by erikwright (departed)

Modified:
9 years ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add an out-of-line destructor to this class. They are needed because StringPiece is going to become a template instatiation, and according to the Chromium style-checking Clang plugins, that makes any class with a member StringPiece 'complex'. See http://codereview.chromium.org/8659047/ for the changes to StringPiece. R=aa@chromium.org BUG=87634 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115323

Patch Set 1 #

Patch Set 2 : Explicitly make subclass destructor virtual. #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/renderer/static_v8_external_string_resource.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/renderer/static_v8_external_string_resource.cc	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

lgtm http://codereview.chromium.org/9021001/diff/3001/chrome/renderer/static_v8_external_string_resource.cc File chrome/renderer/static_v8_external_string_resource.cc (right): http://codereview.chromium.org/9021001/diff/3001/chrome/renderer/static_v8_external_string_resource.cc#newcode12 chrome/renderer/static_v8_external_string_resource.cc:12: StaticV8ExternalAsciiStringResource::~StaticV8ExternalAsciiStringResource() { Lucky!

9 years ago (2011-12-21 08:21:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/9021001/3001

9 years ago (2011-12-21 11:39:17 UTC) #3

Change committed as 115323

Expand Messages | Collapse Messages